-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for kubelet instance config #3126
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HirazawaUi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0825734
to
2c7be5a
Compare
/retest |
63cecf7
to
42dd92f
Compare
42dd92f
to
7d1b378
Compare
/cc @neolit123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should do the following (when the FG is enabled):
- kubeadm init with "latest"
- kubeadm join with "latest"
- check that that instance config is on the nodes (it should be there)
- delete the instance config from the nodes
- kubeadm upgrade "latest" (it would be latest->latest technically)
- check if the instance config is on the nodes (it should be there)
testgrid-dashboards: sig-cluster-lifecycle-kubeadm | ||
testgrid-tab-name: kubeadm-kinder-instance-config-{{ dashVer .KubernetesVersion }} | ||
testgrid-alert-email: sig-cluster-lifecycle-kubeadm-alerts@kubernetes.io | ||
description: "OWNER: sig-cluster-lifecycle (kinder); Uses kubeadm/kinder to create a cluster using kubelet instance config and run kubeadm-e2e and the conformance suite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can skip the conformance suite, because it overlaps with other jobs.
- --name={{ .vars.clusterName }} | ||
- --loglevel=debug | ||
timeout: 10m | ||
- name: e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove the conformance e2e task
Add e2e test for kubelet instance config.
relate: kubernetes/test-infra#33807