Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for kubelet instance config #3126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HirazawaUi
Copy link

Add e2e test for kubelet instance config.

relate: kubernetes/test-infra#33807

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HirazawaUi
Once this PR has been reviewed and has the lgtm label, please assign sataqiu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/kinder Issues to track work in the kinder tool label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2024
@HirazawaUi
Copy link
Author

/retest

@HirazawaUi HirazawaUi force-pushed the add-instance-config-tests branch 2 times, most recently from 63cecf7 to 42dd92f Compare November 19, 2024 00:22
@HirazawaUi
Copy link
Author

/cc @neolit123

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should do the following (when the FG is enabled):

  • kubeadm init with "latest"
  • kubeadm join with "latest"
  • check that that instance config is on the nodes (it should be there)
  • delete the instance config from the nodes
  • kubeadm upgrade "latest" (it would be latest->latest technically)
  • check if the instance config is on the nodes (it should be there)

testgrid-dashboards: sig-cluster-lifecycle-kubeadm
testgrid-tab-name: kubeadm-kinder-instance-config-{{ dashVer .KubernetesVersion }}
testgrid-alert-email: sig-cluster-lifecycle-kubeadm-alerts@kubernetes.io
description: "OWNER: sig-cluster-lifecycle (kinder); Uses kubeadm/kinder to create a cluster using kubelet instance config and run kubeadm-e2e and the conformance suite"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can skip the conformance suite, because it overlaps with other jobs.

- --name={{ .vars.clusterName }}
- --loglevel=debug
timeout: 10m
- name: e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the conformance e2e task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants