Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP: Enable Artifact Registry for the Boskos projects #7550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GCP: Enable Artifact Registry for the Boskos projects #7550

wants to merge 1 commit into from
+156 −155

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Nov 21, 2024 •
edited
Loading

Ensure the service is enabled for all the Boskos projects.
It's currently not consistent across the entire list.

Also auto-linting of the bash script.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@ameukam
GCP: Enable Artifact Registry for the Boskos projects
16e0bbc 
Ensure the service is enabled for all the Boskos projects.
It's currently not consistent across the entire list.
Also lint the bash script.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters labels Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2024
@ameukam
Copy link
Member Author

ameukam commented Nov 21, 2024

/hold

cc @kubernetes/sig-k8s-infra-leads

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 21, 2024
@ameukam ameukam requested review from BenTheElder and upodroid and removed request for Verolop and xmudrii November 21, 2024 18:15
@BenTheElder
Copy link
Member

uhhhh maybe we shouldn't do that?

@BenTheElder
Copy link
Member

Do we have retention policies for these? What are we pushing to boskos projects? Which users are doing this?

I could've sworn we only used GCS tarballs for kube-up and kops?

@ameukam
Copy link
Member Author

ameukam commented Nov 21, 2024 •
edited
Loading

I could've sworn we only used GCS tarballs for kube-up and kops?

Some images are built during the execution of an e2e test. The container repository is not deleted after job execution. I found:

gcloud container images list --project k8s-infra-e2e-boskos-117
NAME
gcr.io/k8s-infra-e2e-boskos-117/cloud-controller-manager
gcr.io/k8s-infra-e2e-boskos-117/gcp-filestore-csi-driver
gcr.io/k8s-infra-e2e-boskos-117/gcp-persistent-disk-csi-driver
gcr.io/k8s-infra-e2e-boskos-117/glbc
gcr.io/k8s-infra-e2e-boskos-117/local-volume-provisioner
gcr.io/k8s-infra-e2e-boskos-117/vpa-admission-controller
gcr.io/k8s-infra-e2e-boskos-117/vpa-admission-controller-amd64
gcr.io/k8s-infra-e2e-boskos-117/vpa-recommender
gcr.io/k8s-infra-e2e-boskos-117/vpa-recommender-amd64
gcr.io/k8s-infra-e2e-boskos-117/vpa-updater
gcr.io/k8s-infra-e2e-boskos-117/vpa-updater-amd64

@ameukam
Copy link
Member Author

ameukam commented Nov 21, 2024

Do we have retention policies for these?

We probably want to set this on AR repos if e2e tests continue to produce those images.

@ameukam
Copy link
Member Author

ameukam commented Nov 21, 2024

I think we at least need a container registry for cloud-controller-manager. No exactly sure which tests need this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@upodroid upodroid Awaiting requested review from upodroid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @BenTheElder