Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collect NEGs in to-be-deleted state. #2750

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Garbage collect NEGs in to-be-deleted state. #2750

wants to merge 15 commits into from

Conversation

sawsa307
Copy link
Contributor

@sawsa307
Update namer interface to include NonDefaultSubnetNEG
460f7d6
@sawsa307
Exclude NodeTopologyInformer from hasSynced.
fd001e7 
* Remove NodeTopologyInformer from controller context hasSynced so it
  won't block controllers from starting up in case of the CRD or CR does
  not exist.
@sawsa307
Add NodeTopologyInformer to zoneGetter.
be3c372
@sawsa307
Fall back to only include default if nodeTopology CR isn't ready.
6e42596
@sawsa307
Create additional NEGs based on subnets in Node Topology CR.
055d691 
* Query Node Topology CR for the current set of NEGs in the cluster.
* When ensureNetworkEndpointGroups(), ensure NEGs are properly
  provisioned in the non-default subnets as well.
@sawsa307
Use correct namer based on the NEG type.
927b120
@sawsa307
fixup! Fall back to only include default if nodeTopology CR isn't ready.
2e9a180
@sawsa307
fixup! Create additional NEGs based on subnets in Node Topology CR.
037a763
@sawsa307
fixup! Use correct namer based on the NEG type.
cd6e627
@sawsa307
fixup! Use correct namer based on the NEG type.
7724945
@sawsa307
fixup! Fall back to only include default if nodeTopology CR isn't ready.
20d4578
@sawsa307
Expand NEG GC with isPartialDeletion method.
a4cbb09 
* Existing NEG GC will always delete all GCE NEGs in NEG CR. With
  multi-subnet cluster enabled, we could do partial deletions, only on
  to-be-deleted NEGs.
@sawsa307
NEG GC should consider a SvcNeg as deletion candidate if it contains tbd
611a9a0 
NEGs.
@sawsa307
Refactor TestGarbageCollectionNegCrdEnabled
d2f09fb
@sawsa307
Add tests for GC to-be-deleted NEGs.
b2bf3e0
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please assign gauravkghildiyal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@spencerhance spencerhance Awaiting requested review from spencerhance

Assignees

@swetharepakula swetharepakula

@gauravkghildiyal gauravkghildiyal

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @swetharepakula @gauravkghildiyal