-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hetzner): refactored placement group code #7520
base: master
Are you sure you want to change the base?
refactor(hetzner): refactored placement group code #7520
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lukasmetzner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lukasmetzner. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
// Check if an error occurred | ||
if err != nil { | ||
if errors.Is(err, context.DeadlineExceeded) { | ||
klog.Fatalf("Timed out checking if placement group `%s` exists.", placementGroupRef) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this method we could also return a proper error and then call klog.Fatalf
at the callsite (which does not return an error itself).
What type of PR is this?
/kind cleanup
Optionally add one or more of the following kinds if applicable:
What this PR does / why we need it:
We have received some external contributions, which we want to clean up a little.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: