Add support for ntpsec

[davidumea]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Adds support for ntpsec, required for using ntp when running on Ubuntu 24.04 or when systemd-timesyncd is already installed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added support for using ntpsec

[k8s-ci-robot]

Hi @davidumea. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[davidumea]

I think the pipeline was triggered because the fork wasn't synced or something, but it still needs the needs-ok-to-test label removed for the pipeline to run successfully now.

[yankay]

/ok-to-test

[yankay]

Thanks @davidumea
/approve

[yankay]

Hello @VannTen and @tico88612,
could you please assist in reviewing this?

[tico88612]

Suggested change

	# Only takes effect when ntp_manage_config is true.
	# For ntpsec use '/var/lib/ntpsec/ntp.drift'
	ntp_driftfile: /var/lib/ntp/ntp.drift
	# Only takes effect when ntp_manage_config is true.
	# Default value is `/var/lib/ntp/ntp.drift`, for ntpsec use '/var/lib/ntpsec/ntp.drift'
	ntp_driftfile: >-
	{% if ntp_package == "ntpsec" -%}
	/var/lib/ntpsec/ntp.drift
	{%- else -%}
	/var/lib/ntp/ntp.drift
	{%- endif -%}

WDYT?

[davidumea]

I like it, but should we then also put a default value for when "chrony" is used as ntp_package?

I'm not 100% sure what it should be, but in their documentation (under driftfile) they have /var/lib/chrony/drift as example value. Do you think we can put that here?

[tico88612]

Driftfile is not required to be set, so there is no default value. (only example in documentation)

You can add this in the PR, but if you want to make changes, you may need to write “release note action required” about using the upgraded clusters for notice.

[davidumea]

Okay I didn't realize that it was optional, then I think it makes sense to stick to your suggestion here.

[tico88612]

If you think the previous review is better, this line (Line 56) can be removed.

[tico88612]

/retest-failed

[tico88612]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidumea, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment