Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump operatorpkg with adding additional labels to status condition controllers #1855

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Nov 30, 2024

Fixes #N/A

Description

This bumps operatorpkg to the latest which allows us to inject additional labels into status condition metrics

➜  karpenter-provider-aws git:(main) curl localhost:8080/metrics | grep operator_nodeclaim
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  858k    0  858k    0     0   936k      0 --:--:-- --:--:-- --:--:--  935k# HELP operator_nodeclaim_status_condition_count The number of an condition for a given object, type and status. e.g. Alarm := Available=False > 0
# TYPE operator_nodeclaim_status_condition_count gauge
operator_nodeclaim_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="default-2d4jt",namespace="",reason="AwaitingReconciliation",status="Unknown",type="Initialized"} 1
operator_nodeclaim_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="default-2d4jt",namespace="",reason="AwaitingReconciliation",status="Unknown",type="Launched"} 1
operator_nodeclaim_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="default-9jczn",namespace="",reason="AwaitingReconciliation",status="Unknown",type="Initialized"} 1
operator_nodeclaim_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="default-9jczn",namespace="",reason="AwaitingReconciliation",status="Unknown",type="Launched"} 1
operator_nodeclaim_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="default-f755c",namespace="",reason="AwaitingReconciliation",status="Unknown",type="Initialized"} 1


➜  karpenter-provider-aws git:(main) curl localhost:8080/metrics | grep operator_node_status_condition_count
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  910k    0  910k    0     0   904k      0 --:--:--  0:00:01 --:--:--  904k# HELP operator_node_status_condition_count The number of an condition for a given object, type and status. e.g. Alarm := Available=False > 0
# TYPE operator_node_status_condition_count gauge
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="",karpenter_sh_nodepool="",name="fargate-ip-192-168-107-123.us-west-2.compute.internal",namespace="",reason="KubeletHasNoDiskPressure",status="False",type="DiskPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="",karpenter_sh_nodepool="",name="fargate-ip-192-168-107-123.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientMemory",status="False",type="MemoryPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-42-26.us-west-2.compute.internal",namespace="",reason="KubeletReady",status="True",type="Ready"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-45-170.us-west-2.compute.internal",namespace="",reason="KubeletHasNoDiskPressure",status="False",type="DiskPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-45-170.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientMemory",status="False",type="MemoryPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-45-170.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientPID",status="False",type="PIDPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-45-170.us-west-2.compute.internal",namespace="",reason="KubeletReady",status="True",type="Ready"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-53-168.us-west-2.compute.internal",namespace="",reason="KubeletHasNoDiskPressure",status="False",type="DiskPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-53-168.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientMemory",status="False",type="MemoryPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-53-168.us-west-2.compute.internal",namespace="",reason="KubeletHasSufficientPID",status="False",type="PIDPressure"} 1
operator_node_status_condition_count{karpenter_k8s_aws_ec2nodeclass="default",karpenter_sh_nodepool="default",name="ip-192-168-53-168.us-west-2.compute.internal",namespace="",reason="KubeletReady",status="True",type="Ready"} 1

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12094313899

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 80.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/cachesyncingclient.go 2 82.29%
pkg/utils/termination/termination.go 2 87.18%
pkg/controllers/node/termination/controller.go 5 69.07%
Totals Coverage Status
Change from base Build 12092791152: -0.05%
Covered Lines: 8917
Relevant Lines: 11068

💛 - Coveralls

@jmdeal
Copy link
Member

jmdeal commented Nov 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit cddecaa into kubernetes-sigs:main Nov 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants