-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4811 from tanujd11/feat/azure-zone-list-cache
feat: add azure zone list cache
- Loading branch information
Showing
10 changed files
with
163 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/* | ||
Copyright 2024 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package azure | ||
|
||
import ( | ||
"time" | ||
) | ||
|
||
// zonesCache is a cache for Azure zones(private or public) | ||
type zonesCache[T any] struct { | ||
age time.Time | ||
duration time.Duration | ||
zones []T | ||
} | ||
|
||
// Reset method to reset the zones and update the age. This will be used to update the cache | ||
// after making a new API call to get the zones. | ||
func (z *zonesCache[T]) Reset(zones []T) { | ||
if z.duration > time.Duration(0) { | ||
z.age = time.Now() | ||
z.zones = zones | ||
} | ||
} | ||
|
||
// Get method to retrieve the cached zones. If cache is not expired, this will be used | ||
// instead of making a new API call to get the zones. | ||
func (z *zonesCache[T]) Get() []T { | ||
return z.zones | ||
} | ||
|
||
// Expired method to check if the cache has expired based on duration or if zones are empty. | ||
// If cache is expired, a new API call will be made to get the zones. If zones are empty, a new | ||
// API call will be made to get the zones. This case comes in at the time of initialization. | ||
func (z *zonesCache[T]) Expired() bool { | ||
return len(z.zones) < 1 || time.Since(z.age) > z.duration | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/* | ||
Copyright 2024 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package azure | ||
|
||
import ( | ||
"testing" | ||
"time" | ||
|
||
dns "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/dns/armdns" | ||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestzonesCache(t *testing.T) { | ||
now := time.Now() | ||
zoneName := "example.com" | ||
var testCases = map[string]struct { | ||
z *zonesCache[dns.Zone] | ||
expired bool | ||
}{ | ||
"inactive-zone-cache": { | ||
&zonesCache[dns.Zone]{ | ||
duration: 0 * time.Second, | ||
}, | ||
true, | ||
}, | ||
"empty-active-zone-cache": { | ||
&zonesCache[dns.Zone]{ | ||
duration: 30 * time.Second, | ||
}, | ||
true, | ||
}, | ||
"expired-zone-cache": { | ||
&zonesCache[dns.Zone]{ | ||
age: now.Add(-300 * time.Second), | ||
duration: 30 * time.Second, | ||
}, | ||
true, | ||
}, | ||
"active-zone-cache": { | ||
&zonesCache[dns.Zone]{ | ||
zones: []dns.Zone{{ | ||
Name: &zoneName, | ||
}}, | ||
duration: 30 * time.Second, | ||
age: now, | ||
}, | ||
false, | ||
}, | ||
} | ||
|
||
for name, testCase := range testCases { | ||
t.Run(name, func(t *testing.T) { | ||
assert.Equal(t, testCase.expired, testCase.z.Expired()) | ||
var resetZoneLength = 1 | ||
if testCase.z.duration == 0 { | ||
resetZoneLength = 0 | ||
} | ||
testCase.z.Reset([]dns.Zone{{ | ||
Name: &zoneName, | ||
}}) | ||
assert.Len(t, testCase.z.Get(), resetZoneLength) | ||
}) | ||
} | ||
} |