-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile documentation #373
Conversation
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
cc @ckadner |
Hi @ddelange apologies for the long wait. I added a quick review to the sister PR here kserve/modelmesh-runtime-adapter#50 |
kserve/modelmesh-runtime-adapter#50 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
- install opposite of uninstall - deploy opposite of undeploy Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ddelange -- while syncing with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you @ddelange
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: ckadner, ddelange The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Motivation
kserve/modelmesh-runtime-adapter#38 (comment)
Modifications
Double hashtag just above the target
Result