🌱 add Review API Test #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
aufi
reviewed
Jul 28, 2023
|
Please don't forget update https://github.com/konveyor/tackle2-hub/blob/main/docs/test-api-matrix.md |
|
Related to konveyor/operator#220 |
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
aufi
reviewed
Aug 1, 2023
test/api/review/api_test.go
Outdated
| assert.Must(t, Application.Delete(app.ID)) | ||
| }) | ||
|
|
||
| t.Run("Delete Review and its dependencies", func(t *testing.T) { |
There was a problem hiding this comment.
Not sure why is application delete before the reviews (so why there is a separated subtets for the deletion).
There was a problem hiding this comment.
Will merge the test!
| } | ||
| assert.Must(t, Application.Create(&destApp)) | ||
|
|
||
| err := Review.Copy(r.ID, destApp.ID) |
There was a problem hiding this comment.
It cold be better check the copied review fields with AssertEqualReviews
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add review API Test
Work to be Done