-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Migrate Pathfinder assessments and remove Pathfinder #276
Conversation
36ca996
to
b06c420
Compare
d2f1174
to
aa00265
Compare
Work in progress mostly because something still seems to need sorting out with the actual migration:
|
60dd37c
to
3c77d23
Compare
cc @djzager for removing the image from GH actions, etc. |
3c77d23
to
9a86294
Compare
name: "{{ pathfinder_database_data_volume_claim_name }}" | ||
namespace: "{{ app_namespace }}" | ||
when: | ||
- (pathfinder_delete_db_volume|bool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the DB volume removal behind a flag since there's no going back. To me it seems like this should be a conscious users decision to make once they feel confident everything is as it should be. They can also delete it manually oc delete pvc ...
.
9a86294
to
d04baac
Compare
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
d04baac
to
1a7cfe1
Compare
From my side, looks great! |
I tested with a clean install and an upgrade this morning. Both seemed to go fine, and in the case of the upgrade assessments were copied over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that the changes to this file were for completeness. I'm not aware of anything we are currently using that relies on this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just trying to remove all references to Pathfinder. I can follow up with a PR to drop the file so we can re-add it easily if we discover something does use it.
No description provided.