Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Migrate Pathfinder assessments and remove Pathfinder #276

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

jmontleon
Copy link
Member

No description provided.

@jmontleon jmontleon marked this pull request as draft October 31, 2023 17:25
@jmontleon jmontleon force-pushed the migrate-pathfinder branch 2 times, most recently from d2f1174 to aa00265 Compare October 31, 2023 17:30
@jmontleon
Copy link
Member Author

Work in progress mostly because something still seems to need sorting out with the actual migration:

Starting Pathfinder Assessments to Konveyor Assessment migration.
There are 10 Applications, looking for their Assessments..
# Assessment for Application 83
Traceback (most recent call last):
  File "/usr/local/bin/migrate-pathfinder-assessments.py", line 124, in <module>
    appCnt = migrateAssessments(args.pathfinder_url, args.hub_base_url, args.token)
  File "/usr/local/bin/migrate-pathfinder-assessments.py", line 89, in migrateAssessments
    for sh in passmnt['stakeholders']:
KeyError: 'stakeholders'

@jmontleon jmontleon force-pushed the migrate-pathfinder branch 3 times, most recently from 60dd37c to 3c77d23 Compare October 31, 2023 20:16
@jmontleon
Copy link
Member Author

cc @djzager for removing the image from GH actions, etc.

name: "{{ pathfinder_database_data_volume_claim_name }}"
namespace: "{{ app_namespace }}"
when:
- (pathfinder_delete_db_volume|bool)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the DB volume removal behind a flag since there's no going back. To me it seems like this should be a conscious users decision to make once they feel confident everything is as it should be. They can also delete it manually oc delete pvc ....

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
@aufi
Copy link
Member

aufi commented Nov 1, 2023

From my side, looks great!

@jmontleon jmontleon marked this pull request as ready for review November 1, 2023 13:31
@jmontleon
Copy link
Member Author

jmontleon commented Nov 1, 2023

I tested with a clean install and an upgrade this morning. Both seemed to go fine, and in the case of the upgrade assessments were copied over.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the changes to this file were for completeness. I'm not aware of anything we are currently using that relies on this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just trying to remove all references to Pathfinder. I can follow up with a PR to drop the file so we can re-add it easily if we discover something does use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants