feat: make the image repo/username/name configurable #165
Conversation
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
|
Thanks for making a pull request! 😃 |
| @@ -30,7 +30,7 @@ spec: | |||
| {{- end }} | |||
| containers: | |||
| - name: move2kubeapi | |||
| image: "quay.io/konveyor/move2kube-ui:{{ .Values.deployment.api.imageTag | default .Chart.AppVersion }}" | |||
| image: "{{ .Values.deployment.api.imageName }}:{{ .Values.deployment.api.imageTag | default .Chart.AppVersion }}" | |||
There was a problem hiding this comment.
| image: "{{ .Values.deployment.api.imageName }}:{{ .Values.deployment.api.imageTag | default .Chart.AppVersion }}" | |
| image: "{{ .Values.deployment.api.imageName | default quay.io/konveyor/move2kube-ui }}:{{ .Values.deployment.api.imageTag | default .Chart.AppVersion }}" |
There was a problem hiding this comment.
@ashokponkumar should there be default for the image tag as well?
There was a problem hiding this comment.
the chart appV?erison is the default there already.
There was a problem hiding this comment.
we have a default in the values.yaml
There was a problem hiding this comment.
Why not have it here?
That's not the right place for it.
We have lots of defaults, not just the imageName. They are all in the values.yaml.
There was a problem hiding this comment.
This is a default tha tomato users should not change. Those which most users should configure should go in values.yaml, and others can go in the respective yamla. It also allows users who are looking at the yamls to have complete information.
No description provided.