Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test run with prompt adjustments from PR146 #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmontleon
Copy link

@jmontleon jmontleon commented Apr 9, 2024

Some manual comparison

pom.xml - several differences, not sure how severe they are

src/main/java/com/redhat/coolstore/model/InventoryEntity.java - only newline @eof
src/main/java/com/redhat/coolstore/model/Order.java - only newline @eof
src/main/java/com/redhat/coolstore/model/OrderItem.java - only newline @eof


src/main/java/com/redhat/coolstore/persistence/(Resources.java) - completely different

src/main/java/com/redhat/coolstore/rest/CartEndpoint.java - only a blank line
src/main/java/com/redhat/coolstore/rest/OrderEndpoint.java - only a blank line
src/main/java/com/redhat/coolstore/rest/ProductEndpoint.java - no difference
src/main/java/com/redhat/coolstore/rest/RestApplication.java - ApplicationPath import and annotation

src/main/java/com/redhat/coolstore/service/CatalogService.java - missed imports application scoped annotation
src/main/java/com/redhat/coolstore/service/InventoryNotificationMDB.java - very different
src/main/java/com/redhat/coolstore/service/OrderService.java - missed applicationscoped import
src/main/java/com/redhat/coolstore/service/OrderServiceMDB.java - pretty different
src/main/java/com/redhat/coolstore/service/ProductService.java - used applicationscoped instead of requestscoped
src/main/java/com/redhat/coolstore/service/PromoService.java - no difference
src/main/java/com/redhat/coolstore/service/ShippingService.java - very different
src/main/java/com/redhat/coolstore/service/ShoppingCartOrderProcessor.java - aplication vs requestscoped again, other differences
src/main/java/com/redhat/coolstore/service/ShoppingCartService.java - pretty different

src/main/java/com/redhat/coolstore/utils/DataBaseMigrationStartup.java - very different
src/main/java/com/redhat/coolstore/utils/Producers.java - very different
src/main/java/com/redhat/coolstore/utils/StartupListener.java - completely different
src/main/java/com/redhat/coolstore/utils/Transformers.java - no difference

src/main/resources/META-INF/persistence.xml - completely different

src/main/webapp/WEB-INF/beans.xml - completely different

src/main/webapp/WEB-INF/web.xml - completely different

@jmontleon jmontleon force-pushed the 20240409-pr146-prompt branch 3 times, most recently from 2805a79 to 5df454e Compare April 9, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant