Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v18 #390

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Release v18 #390

merged 2 commits into from
Feb 27, 2024

Conversation

pokornyd
Copy link
Member

Motivation

Fixes #377

Target set to .NET 8.0, all references to project modified to environment

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@pokornyd pokornyd requested a review from a team as a code owner February 26, 2024 14:45
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (665b34b) to head (23e7015).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files         129      129           
  Lines        2775     2775           
  Branches      345      345           
=======================================
  Hits         2458     2458           
  Misses        185      185           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriLojda JiriLojda self-requested a review February 27, 2024 13:44
Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -34,7 +34,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update to setup-dotnet@v4 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "project" to "environment"
2 participants