Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

386 introduce workflow property to response #387

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

Sevitas
Copy link
Contributor

@Sevitas Sevitas commented Nov 29, 2023

Motivation

Fixes #386
introduce workflow property

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Check if workflow is retrieved via client

@Sevitas Sevitas requested review from pokornyd and a team as code owners November 29, 2023 09:45
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f20d1d) 88.57% compared to head (7f6341f) 88.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files         129      129           
  Lines        2774     2775    +1     
  Branches      345      345           
=======================================
+ Hits         2457     2458    +1     
  Misses        185      185           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sevitas Sevitas changed the title 386 introduce workflow property to response 386 introduce workflow property to response [DoNotMerge] Dec 4, 2023
@Sevitas Sevitas force-pushed the feature/386_workflow_codename branch from 7e44b51 to 0e7522a Compare December 4, 2023 13:59
@Sevitas Sevitas changed the title 386 introduce workflow property to response [DoNotMerge] 386 introduce workflow property to response Dec 12, 2023
@@ -27,6 +27,11 @@ public interface IContentItemSystemAttributes : ISystemAttributes
/// </summary>
public string Collection { get; }

/// <summary>
/// Gets the codename of the workflow which the content item is assigned to .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra space at the end of the comment

/// Gets the codename of the workflow which the content item is assigned to .
/// </summary>
public string Workflow { get; }

/// <summary>
/// Gets the codename of the workflow step which the content item is assigned to .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtto

@pokornyd
Copy link
Member

codecov fails because you don't have permissions to upload the SBOM, should fix itself after merge. otherwise looking good

pokornyd
pokornyd previously approved these changes Dec 12, 2023
@pokornyd pokornyd merged commit b52860b into kontent-ai:master Dec 12, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worfklow codename in DAPI response
2 participants