Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: return a value of grn_rc type instead of void #3

Open
wants to merge 78 commits into
base: main
Choose a base branch
from

Commits on Sep 15, 2024

  1. Use bool instead of grn_bool in proc.c

    groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    Not all of proc.c has been replaced. In this commit, only some of it was replaced.
    abetomo committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    a0e687f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Use bool instead of grn_bool in index_column.c

    groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    Not all of index_column.c has been replaced. In this commit, only some of it was replaced.
    abetomo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b9a0d19 View commit details
    Browse the repository at this point in the history
  2. Unify the return value of grn_obj_is_reference_column() with bool

    groongaGH-1638
    
    grn_bool and bool were mixed up.
    abetomo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4d5afe7 View commit details
    Browse the repository at this point in the history
  3. Use bool instead of grn_bool in index_column.c

    groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    abetomo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    34a5626 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. docs: api/grn_table: move grn_table_update_by_id() reference to the h…

    …eader file (groonga#1954)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    031f9bb View commit details
    Browse the repository at this point in the history
  2. docs: api/grn_table: move grn_table_get_key() reference to the header…

    … file (groonga#1958)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2025bd9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. ci: Use macos-latest

    macos-12 is deprecated.
    kou committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e6f3906 View commit details
    Browse the repository at this point in the history
  2. doc news: add 14.0.8 entry (groonga#1960)

    Co-authored-by: takuya kodama <otegami@clear-code.com>
    komainu8 and otegami authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8c50480 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07e184c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    c96d257 View commit details
    Browse the repository at this point in the history
  2. status: add "os" and "cpu"

    kou committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bae10d5 View commit details
    Browse the repository at this point in the history
  3. test TokenDocumentVectorBM25: omit on macOS

    It seems that macOS has different floating point number precision than
    Linux.
    kou committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    20325df View commit details
    Browse the repository at this point in the history
  4. ci macos autotools: remove TokenDocumentVectorBM25 tests

    We'll drop support for GNU Autotools soon. So we don't want to
    maintain this case.
    kou committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1b42ce0 View commit details
    Browse the repository at this point in the history
  5. Bump version

    komainu8 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ba4a896 View commit details
    Browse the repository at this point in the history
  6. ci: add Alpine Linux 3.20 (groonga#1963)

    This also fixes a build error on Alpine Linux 3.20.
    kou authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a6e5286 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    451fe74 View commit details
    Browse the repository at this point in the history
  8. Use bool instead of grn_bool in geo.c

    groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    Not all of geo.c has been replaced. In this commit, only some of it was replaced.
    abetomo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5fcf66b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. docs: api/grn_table: move grn_table_setoperation() reference to the h…

    …eader file (groonga#1964)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e7c38a8 View commit details
    Browse the repository at this point in the history
  2. docs: api/grn_obj: move grn_obj_path() reference to the header file (g…

    …roonga#1965)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4651fea View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. docs: api/grn_table: move grn_table_lcp_search() reference to the hea…

    …der file (groonga#1968)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    951c107 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    01af3f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c3a9e68 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Change unify_prolonged_sound_mark and unify_middle_dot in grn_nfkc_no…

    …rmalize_options from grn_bool to bool
    
    GitHub: groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    abetomo committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    29fe206 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Change ctx->impl->output.is_pretty from grn_bool to bool

    GitHub: groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    abetomo committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1bc1e2b View commit details
    Browse the repository at this point in the history
  2. docs: api/grn_table: move grn_table_group() reference to the header f…

    …ile (groonga#1971)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e42ad42 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Bump version

    komainu8 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0ea1a41 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b59d43 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. docs: api/grn_obj: move grn_obj_name() reference to the header file (g…

    …roonga#1969)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b20a146 View commit details
    Browse the repository at this point in the history
  2. docs: api/grn_obj: move grn_obj_get_range() reference to the header f…

    …ile (groonga#1973)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bfcbef0 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. docs: api/grn_match_escalation: move grn_*_match_escalation_threshold…

    …() reference to the header file (groonga#1974)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    00ebf88 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Use bool instead of grn_bool in db.c

    groongaGH-1638
    
    This is part of the task of replacing grn_bool with bool.
    Not all of db.c has been replaced. In this commit, only some of it was replaced.
    abetomo committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cf626cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ad6118 View commit details
    Browse the repository at this point in the history
  3. docs: api/grn_obj: move grn_obj_expire() reference to the header file (

    …groonga#1975)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a5bf42e View commit details
    Browse the repository at this point in the history
  4. docs: Add unify_latin_alphabet_with option to NormalizerNFKC150 (groo…

    …nga#1978)
    
    To improve maintainability, we have plans to change the structure of the
    documentation.
    That plan will consolidate the options into one page.
    So I have only added it to NormalizerNFKC150 in this commit.
    abetomo authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    167ba71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b001fd6 View commit details
    Browse the repository at this point in the history
  6. docs: Add unify_to_katakana option to NormalizerNFKC150 (groonga#1979)

    To improve maintainability, we have plans to change the structure of the
    documentation.
    That plan will consolidate the options into one page.
    So I have only added it to NormalizerNFKC150 in this commit.
    abetomo authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b302940 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a8d4e15 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. docs: api/grn_obj: move grn_obj_check() reference to the header file (g…

    …roonga#1981)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4c64e27 View commit details
    Browse the repository at this point in the history
  2. docs: api/grn_db: move grn_db_unmap() reference to the header file (g…

    …roonga#1980)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7e4fe65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ddc467 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4c635a View commit details
    Browse the repository at this point in the history
  5. doc: add missing "." to params

    kou committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2c35004 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48b0ec9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2a987e7 View commit details
    Browse the repository at this point in the history
  8. grn_language_model*: add

    It provides language model related features. It provides only
    vectorization (text -> embeddings conversion) feature for now. It will
    also provide more features such as batch vectorization and text
    generation in the feature.
    
    This is based on llama.cpp.
    kou committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2fce07f View commit details
    Browse the repository at this point in the history
  9. language_model_vectorize: add

    This is still an experimental feature.
    kou committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    15dfa13 View commit details
    Browse the repository at this point in the history
  10. Fix typos

    kou committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    06e4200 View commit details
    Browse the repository at this point in the history
  11. language_mode: apply formatter

    I thought that formatter is applied but not...
    kou committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    22e55bd View commit details
    Browse the repository at this point in the history
  12. autotools: fix extension

    kou committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d6cd635 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a2e895b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    40a83fd View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c157fc7 View commit details
    Browse the repository at this point in the history
  16. language_model.h: Fix the typo (groonga#1982)

    infererncer ->
    inferencer
    abetomo authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    07e5701 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6cb103b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. gqtp client: fix a bug that INVALID_ARGUMENT is 65514 not -22

    RC must be treated as int16_t not int32_t or something.
    kou committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    5c97521 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. docs: api/grn_obj: move grn_obj_lock() reference to the header file (g…

    …roonga#1983)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1f4f2f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4108ea0 View commit details
    Browse the repository at this point in the history
  3. docs: api/grn_obj: move grn_obj_unlock() reference to the header file (

    …groonga#1986)
    
    GitHub: groonga#1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f3e4de1 View commit details
    Browse the repository at this point in the history
  4. docs: api/grn_db: move grn_db_recover() reference to the header file (g…

    …roonga#1985)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c70e7bb View commit details
    Browse the repository at this point in the history
  5. docs: api/grn_db: move grn_db_touch() reference to the header file (g…

    …roonga#1988)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f34d9c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. ci macos: temporarily disable mruby test on macos-latest (groonga#1989)

    Because there is a rpath issue in Rroonga.
    Once resolved, we should enable mruby test on macos-latest.
    otegami authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c39719a View commit details
    Browse the repository at this point in the history
  2. docs: api/grn_db: move grn_db_(create|open) reference to the header f…

    …ile (groonga#1990)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    84c6a70 View commit details
    Browse the repository at this point in the history
  3. docs: api/grn_search: move grn_obj_search() reference to the header f…

    …ile (groonga#1991)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0437b0d View commit details
    Browse the repository at this point in the history
  4. docs: api/grn_db: move grn_obj_db() reference to the header file (gro…

    …onga#1992)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    088a1a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. grn_obj_close: do nothing and return GRN_SUCCESS for NULL (groonga#1957)

    Generally, functions for release resource do nothing when NULL is
    specified like "free(NULL)".
    
    This changes API but this doesn't break backward compatibility.
    Because no code exist that use the return value of `grn_obj_close()`
    when we specify `grn_obj_close(ctx, NULL)` as below.
    
    ---
    
    Following functions use the return value of `grn_obj_close()`.
    
    ```
    ./lib/com.c:  if (ctx == msg->ctx) { return grn_obj_close(ctx, obj); }
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  rc = grn_obj_close(ctx, obj);
    ./lib/db.c:  return grn_obj_close(ctx, obj); 
    ```
    
    ---
    
    `grn_obj_close()` is used in `grn_msg_close()`.
    However, the return value of `grn_msg_close()` uses no one.
    
    ```
    % grep -r grn_msg_close ./**/*.c
    ./lib/com.c:grn_msg_close(grn_ctx *ctx, grn_obj *obj)
    ./lib/com.c:    grn_msg_close(ctx, msg);
    ./lib/com.c:    grn_msg_close(ctx, msg);
    ./src/grnslap.c:  grn_msg_close(ctx, msg);
    ./src/groonga.c:        grn_msg_close(&edge->ctx, msg);
    ./src/groonga.c:        grn_msg_close(ctx, msg);
    ./src/groonga.c:        grn_msg_close(&edge->ctx, obj);
    ./src/groonga.c:        grn_msg_close(ctx, obj);
    ./src/groonga.c:  grn_msg_close(ctx, (grn_obj *)msg);
    ./src/groonga.c:    grn_msg_close(ctx, msg);
    ./src/groonga.c:          grn_msg_close(ctx, msg);
    ./src/groonga.c:          grn_msg_close(ctx, msg);
    ./src/groonga.c:    grn_msg_close(ctx, msg);
    ./src/groonga.c:      grn_msg_close(ctx, msg);
    ```
    
    ---
    
    `grn_obj_close()` is used in `grn_obj_remove_other()`.
    `grn_obj_remove_other()` is used in `grn_obj_remove_internal()`.
    
    `grn_obj_remove_internal()` is used as below.
    
    ```
    ./lib/db.c:      rc = grn_obj_remove_internal(ctx, target, flags);
    ./lib/db.c:      rc = grn_obj_remove_internal(ctx, column, flags);
    ./lib/db.c:        rc = grn_obj_remove_internal(ctx, obj, 0);
    ./lib/db.c:          rc = grn_obj_remove_internal(ctx, obj, 0);
    ./lib/db.c:          rc = grn_obj_remove_internal(ctx, obj, 0);
    ./lib/db.c:        rc = grn_obj_remove_internal(ctx, obj, 0);
    ./lib/db.c:          rc = grn_obj_remove_internal(ctx, object, flags);
    ./lib/db.c:          rc = grn_obj_remove_internal(ctx, object, flags);
    ./lib/db.c:      rc = grn_obj_remove_internal(ctx, obj, flags);
    ./lib/db.c:    rc = grn_obj_remove_internal(ctx, obj, flags);
    ./lib/db.c:      rc = grn_obj_remove_internal(ctx, obj, flags);
    ```
    
    ---
    
    `grn_obj_remove_internal()` is used in `remove_index()`.
    However, `grn_obj_remove_internal()` is not called when `target` is
    `NULL` as below.
    
    ```c
        if (!target) { ... }     } else if (target->header.type == GRN_COLUMN_INDEX) {
          // TODO: multicolumn  MULTI_COLUMN_INDEXP
          rc = grn_obj_remove_internal(ctx, target, flags); }
    ```
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in `remove_columns_raw()`
    However, `grn_obj_remove_internal()` is not called when `column` is
    `NULL` as below.
    
    ```c
        if (column) {
          rc = grn_obj_remove_internal(ctx, column, flags);
          if (rc != GRN_SUCCESS) {
            grn_obj_unlink(ctx, column);
            break;
          }
        } ...
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in
    `grn_obj_remove_db_index_columns()`.
    However, `grn_obj_remove_internal()` is not called when `obj` is `NULL`
    as below.
    
    ```c
          if (obj && obj->header.type == GRN_COLUMN_INDEX) {
            rc = grn_obj_remove_internal(ctx, obj, 0);
            ...
          }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in
    `grn_obj_remove_db_reference_columns()`.
    However, `grn_obj_remove_internal()` is not called when `obj` is `NULL`
    as below.
    
    ```c
        while ((id = grn_table_cursor_next_inline(ctx, cur)) != GRN_ID_NIL) {
          grn_obj *obj = grn_ctx_at(ctx, id);
          grn_obj *range = NULL;
    
          if (!obj) {
            continue;
          }
    
    ...
    
            switch (range->header.type) {
            case GRN_TABLE_NO_KEY:
            case GRN_TABLE_HASH_KEY:
            case GRN_TABLE_PAT_KEY:
            case GRN_TABLE_DAT_KEY:
              rc = grn_obj_remove_internal(ctx, obj, 0);
              break;
            }
    ...
        }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in
    `grn_obj_remove_db_reference_tables()`.
    However, `grn_obj_remove_internal()` is not called when `obj` is `NULL`
    as below.
    
    ```c
        while ((id = grn_table_cursor_next_inline(ctx, cur)) != GRN_ID_NIL) {
          grn_obj *obj = grn_ctx_at(ctx, id);
          grn_obj *domain = NULL;
    
          if (!obj) {
            continue;
          }
    
    ...
    
            switch (domain->header.type) {
            case GRN_TABLE_NO_KEY:
            case GRN_TABLE_HASH_KEY:
            case GRN_TABLE_PAT_KEY:
            case GRN_TABLE_DAT_KEY:
              rc = grn_obj_remove_internal(ctx, obj, 0);
              break;
            }
    
    ...
    
        }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in `grn_obj_remove_db_all_tables()`
    However, `grn_obj_remove_internal()` is not called when `obj` is `NULL`
    as below.
    
    ```c
        while ((id = grn_table_cursor_next_inline(ctx, cur)) != GRN_ID_NIL) {
          grn_obj *obj = grn_ctx_at(ctx, id);
    
          if (!obj) {
            continue;
          }
    
    ...
    
          switch (obj->header.type) {
          case GRN_TABLE_NO_KEY:
          case GRN_TABLE_HASH_KEY:
          case GRN_TABLE_PAT_KEY:
          case GRN_TABLE_DAT_KEY:
            rc = grn_obj_remove_internal(ctx, obj, 0);
            break;
          }
    
    ...
    
        }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in `remove_reference_tables_raw()`.
    However, `grn_obj_remove_internal()` is not called when `object` is
    `NULL` as below.
    
    ```c
          object = grn_ctx_at(ctx, id);
          if (!object) {
    
            ...
    
          switch (object->header.type) {
          case GRN_TABLE_HASH_KEY:
          case GRN_TABLE_PAT_KEY:
          case GRN_TABLE_DAT_KEY:
            if (DB_OBJ(object)->id == table_id) {
              break;
            }
    
            if (object->header.domain == table_id) {
              rc = grn_obj_remove_internal(ctx, object, flags);
              is_removed = (grn_table_at(ctx, db, id) == GRN_ID_NIL);
            }
            break;
    
          ...
    
          case GRN_COLUMN_VAR_SIZE:
          case GRN_COLUMN_FIX_SIZE:
            if (object->header.domain == table_id) {
              break;
            }
            if (DB_OBJ(object)->range == table_id) {
              rc = grn_obj_remove_internal(ctx, object, flags);
              is_removed = (grn_table_at(ctx, db, id) == GRN_ID_NIL);
            }
            break;
    
          ...
        }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_internal()` is used in
    `grn_ctx_remove_by_id_internal()`.
    However, `grn_obj_remove_internal()` is not called when `obj` is `NULL`
    as below.
    
    ```c
      if (obj) {
        grn_rc rc;
        if (is_top_level) {
          rc = grn_obj_remove_flags(ctx, obj, flags);
        } else {
          rc = grn_obj_remove_internal(ctx, obj, flags);
        }
        ...
      }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_flags()` is used as below.
    
    ```
    ./lib/db.c:  return grn_obj_remove_flags(ctx, obj, 0);
    ./lib/db.c:  return grn_obj_remove_flags(ctx, obj, GRN_OBJ_REMOVE_DEPENDENT);
    ./lib/db.c:    grn_rc rc = grn_obj_remove_flags(ctx, obj, flags);
    ./lib/db.c:      rc = grn_obj_remove_flags(ctx, obj, flags);
    ```
    
    `grn_obj_remove_flags()` is used in `grn_ctx_remove_by_id_internal()`.
    However, `grn_obj_remove_flags()` is not called when `obj` is `NULL` as
    below.
    
    ```c
      if (obj) {
        grn_rc rc;
        if (is_top_level) {
          rc = grn_obj_remove_flags(ctx, obj, flags);
        } else {
          rc = grn_obj_remove_internal(ctx, obj, flags);
        }
        ...
      }
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_flags()` is used in `grn_obj_remove_dependent()`.
    However, the return value of `grn_obj_remove_dependent()` uses no one.
    
    ```
    % grep -r grn_obj_remove_dependent ./**/*.c
    ./lib/db.c:grn_obj_remove_dependent(grn_ctx *ctx, grn_obj *obj)
    ```
    
    ---
    
    `grn_obj_remove_flags()` is used in `grn_ctx_remove()`.
    However, `grn_obj_remove_flags()` is not called when `obj` is `NULL` as
    below.
    
    ```c
      grn_obj *obj = grn_ctx_get(ctx, name, name_size);
      if (obj) {
        grn_rc rc = grn_obj_remove_flags(ctx, obj, flags);
        if (rc == GRN_SUCCESS) {
          GRN_API_RETURN(rc);
        }
        if (!(flags & GRN_OBJ_REMOVE_ENSURE)) {
          GRN_API_RETURN(rc);
        }
      } ...
    ```
    
    So, this changes API does not affect. 
    
    ---
    
    `grn_obj_remove_flags()` is used in `grn_ctx_remove_by_id_internal()`
    However, `grn_obj_remove_flags()` is not called when `obj` is `NULL` as
    below.
    
    ```c
      grn_obj *obj = grn_ctx_at(ctx, id);
      if (obj) {
        grn_rc rc;
        if (is_top_level) {
          rc = grn_obj_remove_flags(ctx, obj, flags);
        } else {
          rc = grn_obj_remove_internal(ctx, obj, flags);
        }
    ```
    
    So, this changes API does not affect.
    komainu8 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6620d73 View commit details
    Browse the repository at this point in the history
  2. grn_obj_close: check GRN_OBJ_ALLOCATED before grn_bulk_fin()

    grn_bulk_fin() may clear header.impl_flags in the future.
    kou committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    562aa17 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. docs: api/grn_obj: move grn_obj_clear_lock() reference to the header …

    …file (groonga#1994)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    52d4e34 View commit details
    Browse the repository at this point in the history
  2. package: windows: Add vcomp140.dll to with-vcruntime package (groon…

    …ga#1993)
    
    Fix the missing DLL error.
    abetomo authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a9000cb View commit details
    Browse the repository at this point in the history
  3. docs: api/grn_obj: move grn_obj_is_locked() reference to the header f…

    …ile (groonga#1995)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    otegami authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9b30275 View commit details
    Browse the repository at this point in the history
  4. docs: api/grn_proc: move grn_obj_set_finalizer() reference to the hea…

    …der file (groonga#1997)
    
    GitHub: groongaGH-1817
    
    Prepare to switch to documents automatically generated by Doxygen.
    abetomo authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cbe7038 View commit details
    Browse the repository at this point in the history
  5. docs: clarify differences between grn_obj_unlock() and grn_obj_clear_…

    …lock() about lock management (groonga#1996)
    otegami authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a6df032 View commit details
    Browse the repository at this point in the history
  6. db: return a value of grn_rc type instead of void

    Because grn_obj_unlink() may return GRN_INVALID_ARGUMENT when error
    occurs in this function.
    Also, grn_obj_close() return a value of grn_rc.
    komainu8 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bd24995 View commit details
    Browse the repository at this point in the history
  7. Simplify

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    komainu8 and kou committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2f154ac View commit details
    Browse the repository at this point in the history
  8. Simplify

    komainu8 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ee23eb0 View commit details
    Browse the repository at this point in the history
  9. Reduce scope for rc

    komainu8 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0c5d496 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2a2a485 View commit details
    Browse the repository at this point in the history
  11. Remove needless declaration

    komainu8 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    edae2eb View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. DRY

    kou authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1391e9e View commit details
    Browse the repository at this point in the history