-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db: return a value of grn_rc type instead of void #3
base: main
Are you sure you want to change the base?
Commits on Sep 15, 2024
-
Use bool instead of grn_bool in proc.c
groongaGH-1638 This is part of the task of replacing grn_bool with bool. Not all of proc.c has been replaced. In this commit, only some of it was replaced.
Configuration menu - View commit details
-
Copy full SHA for a0e687f - Browse repository at this point
Copy the full SHA a0e687fView commit details
Commits on Sep 16, 2024
-
Use bool instead of grn_bool in index_column.c
groongaGH-1638 This is part of the task of replacing grn_bool with bool. Not all of index_column.c has been replaced. In this commit, only some of it was replaced.
Configuration menu - View commit details
-
Copy full SHA for b9a0d19 - Browse repository at this point
Copy the full SHA b9a0d19View commit details -
Unify the return value of grn_obj_is_reference_column() with bool
groongaGH-1638 grn_bool and bool were mixed up.
Configuration menu - View commit details
-
Copy full SHA for 4d5afe7 - Browse repository at this point
Copy the full SHA 4d5afe7View commit details -
Use bool instead of grn_bool in index_column.c
groongaGH-1638 This is part of the task of replacing grn_bool with bool.
Configuration menu - View commit details
-
Copy full SHA for 34a5626 - Browse repository at this point
Copy the full SHA 34a5626View commit details
Commits on Sep 20, 2024
-
docs: api/grn_table: move grn_table_update_by_id() reference to the h…
…eader file (groonga#1954) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 031f9bb - Browse repository at this point
Copy the full SHA 031f9bbView commit details -
docs: api/grn_table: move grn_table_get_key() reference to the header…
… file (groonga#1958) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 2025bd9 - Browse repository at this point
Copy the full SHA 2025bd9View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e6f3906 - Browse repository at this point
Copy the full SHA e6f3906View commit details -
doc news: add 14.0.8 entry (groonga#1960)
Co-authored-by: takuya kodama <otegami@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 8c50480 - Browse repository at this point
Copy the full SHA 8c50480View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07e184c - Browse repository at this point
Copy the full SHA 07e184cView commit details
Commits on Sep 25, 2024
-
doc contribution/documentation: add an outline (groonga#1786)
GitHub: fix groongaGH-1733 See also: groongaGH-1732
Configuration menu - View commit details
-
Copy full SHA for c96d257 - Browse repository at this point
Copy the full SHA c96d257View commit details -
Configuration menu - View commit details
-
Copy full SHA for bae10d5 - Browse repository at this point
Copy the full SHA bae10d5View commit details -
test TokenDocumentVectorBM25: omit on macOS
It seems that macOS has different floating point number precision than Linux.
Configuration menu - View commit details
-
Copy full SHA for 20325df - Browse repository at this point
Copy the full SHA 20325dfView commit details -
ci macos autotools: remove TokenDocumentVectorBM25 tests
We'll drop support for GNU Autotools soon. So we don't want to maintain this case.
Configuration menu - View commit details
-
Copy full SHA for 1b42ce0 - Browse repository at this point
Copy the full SHA 1b42ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba4a896 - Browse repository at this point
Copy the full SHA ba4a896View commit details -
ci: add Alpine Linux 3.20 (groonga#1963)
This also fixes a build error on Alpine Linux 3.20.
Configuration menu - View commit details
-
Copy full SHA for a6e5286 - Browse repository at this point
Copy the full SHA a6e5286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 451fe74 - Browse repository at this point
Copy the full SHA 451fe74View commit details -
Use bool instead of grn_bool in geo.c
groongaGH-1638 This is part of the task of replacing grn_bool with bool. Not all of geo.c has been replaced. In this commit, only some of it was replaced.
Configuration menu - View commit details
-
Copy full SHA for 5fcf66b - Browse repository at this point
Copy the full SHA 5fcf66bView commit details
Commits on Sep 26, 2024
-
docs: api/grn_table: move grn_table_setoperation() reference to the h…
…eader file (groonga#1964) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for e7c38a8 - Browse repository at this point
Copy the full SHA e7c38a8View commit details -
docs: api/grn_obj: move grn_obj_path() reference to the header file (g…
…roonga#1965) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 4651fea - Browse repository at this point
Copy the full SHA 4651feaView commit details
Commits on Sep 27, 2024
-
docs: api/grn_table: move grn_table_lcp_search() reference to the hea…
…der file (groonga#1968) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 951c107 - Browse repository at this point
Copy the full SHA 951c107View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01af3f8 - Browse repository at this point
Copy the full SHA 01af3f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3a9e68 - Browse repository at this point
Copy the full SHA c3a9e68View commit details
Commits on Sep 28, 2024
-
Change unify_prolonged_sound_mark and unify_middle_dot in grn_nfkc_no…
…rmalize_options from grn_bool to bool GitHub: groongaGH-1638 This is part of the task of replacing grn_bool with bool.
Configuration menu - View commit details
-
Copy full SHA for 29fe206 - Browse repository at this point
Copy the full SHA 29fe206View commit details
Commits on Sep 29, 2024
-
Change ctx->impl->output.is_pretty from grn_bool to bool
GitHub: groongaGH-1638 This is part of the task of replacing grn_bool with bool.
Configuration menu - View commit details
-
Copy full SHA for 1bc1e2b - Browse repository at this point
Copy the full SHA 1bc1e2bView commit details -
docs: api/grn_table: move grn_table_group() reference to the header f…
…ile (groonga#1971) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for e42ad42 - Browse repository at this point
Copy the full SHA e42ad42View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0ea1a41 - Browse repository at this point
Copy the full SHA 0ea1a41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b59d43 - Browse repository at this point
Copy the full SHA 4b59d43View commit details
Commits on Oct 1, 2024
-
docs: api/grn_obj: move grn_obj_name() reference to the header file (g…
…roonga#1969) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for b20a146 - Browse repository at this point
Copy the full SHA b20a146View commit details -
docs: api/grn_obj: move grn_obj_get_range() reference to the header f…
…ile (groonga#1973) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for bfcbef0 - Browse repository at this point
Copy the full SHA bfcbef0View commit details
Commits on Oct 2, 2024
-
docs: api/grn_match_escalation: move grn_*_match_escalation_threshold…
…() reference to the header file (groonga#1974) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 00ebf88 - Browse repository at this point
Copy the full SHA 00ebf88View commit details
Commits on Oct 3, 2024
-
Use bool instead of grn_bool in db.c
groongaGH-1638 This is part of the task of replacing grn_bool with bool. Not all of db.c has been replaced. In this commit, only some of it was replaced.
Configuration menu - View commit details
-
Copy full SHA for cf626cc - Browse repository at this point
Copy the full SHA cf626ccView commit details -
Fix the style using '\' instead of '@' (groonga#1977)
Fix the format in groonga#1973.
Configuration menu - View commit details
-
Copy full SHA for 3ad6118 - Browse repository at this point
Copy the full SHA 3ad6118View commit details -
docs: api/grn_obj: move grn_obj_expire() reference to the header file (…
…groonga#1975) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for a5bf42e - Browse repository at this point
Copy the full SHA a5bf42eView commit details -
docs: Add unify_latin_alphabet_with option to NormalizerNFKC150 (groo…
…nga#1978) To improve maintainability, we have plans to change the structure of the documentation. That plan will consolidate the options into one page. So I have only added it to NormalizerNFKC150 in this commit.
Configuration menu - View commit details
-
Copy full SHA for 167ba71 - Browse repository at this point
Copy the full SHA 167ba71View commit details -
Configuration menu - View commit details
-
Copy full SHA for b001fd6 - Browse repository at this point
Copy the full SHA b001fd6View commit details -
docs: Add unify_to_katakana option to NormalizerNFKC150 (groonga#1979)
To improve maintainability, we have plans to change the structure of the documentation. That plan will consolidate the options into one page. So I have only added it to NormalizerNFKC150 in this commit.
Configuration menu - View commit details
-
Copy full SHA for b302940 - Browse repository at this point
Copy the full SHA b302940View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8d4e15 - Browse repository at this point
Copy the full SHA a8d4e15View commit details
Commits on Oct 4, 2024
-
docs: api/grn_obj: move grn_obj_check() reference to the header file (g…
…roonga#1981) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 4c64e27 - Browse repository at this point
Copy the full SHA 4c64e27View commit details -
docs: api/grn_db: move grn_db_unmap() reference to the header file (g…
…roonga#1980) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 7e4fe65 - Browse repository at this point
Copy the full SHA 7e4fe65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ddc467 - Browse repository at this point
Copy the full SHA 5ddc467View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4c635a - Browse repository at this point
Copy the full SHA c4c635aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c35004 - Browse repository at this point
Copy the full SHA 2c35004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48b0ec9 - Browse repository at this point
Copy the full SHA 48b0ec9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a987e7 - Browse repository at this point
Copy the full SHA 2a987e7View commit details -
It provides language model related features. It provides only vectorization (text -> embeddings conversion) feature for now. It will also provide more features such as batch vectorization and text generation in the feature. This is based on llama.cpp.
Configuration menu - View commit details
-
Copy full SHA for 2fce07f - Browse repository at this point
Copy the full SHA 2fce07fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15dfa13 - Browse repository at this point
Copy the full SHA 15dfa13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06e4200 - Browse repository at this point
Copy the full SHA 06e4200View commit details -
language_mode: apply formatter
I thought that formatter is applied but not...
Configuration menu - View commit details
-
Copy full SHA for 22e55bd - Browse repository at this point
Copy the full SHA 22e55bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6cd635 - Browse repository at this point
Copy the full SHA d6cd635View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2e895b - Browse repository at this point
Copy the full SHA a2e895bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40a83fd - Browse repository at this point
Copy the full SHA 40a83fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c157fc7 - Browse repository at this point
Copy the full SHA c157fc7View commit details -
language_model.h: Fix the typo (groonga#1982)
infererncer -> inferencer
Configuration menu - View commit details
-
Copy full SHA for 07e5701 - Browse repository at this point
Copy the full SHA 07e5701View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cb103b - Browse repository at this point
Copy the full SHA 6cb103bView commit details
Commits on Oct 6, 2024
-
gqtp client: fix a bug that INVALID_ARGUMENT is 65514 not -22
RC must be treated as int16_t not int32_t or something.
Configuration menu - View commit details
-
Copy full SHA for 5c97521 - Browse repository at this point
Copy the full SHA 5c97521View commit details
Commits on Oct 7, 2024
-
docs: api/grn_obj: move grn_obj_lock() reference to the header file (g…
…roonga#1983) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 1f4f2f5 - Browse repository at this point
Copy the full SHA 1f4f2f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4108ea0 - Browse repository at this point
Copy the full SHA 4108ea0View commit details -
docs: api/grn_obj: move grn_obj_unlock() reference to the header file (…
…groonga#1986) GitHub: groonga#1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for f3e4de1 - Browse repository at this point
Copy the full SHA f3e4de1View commit details -
docs: api/grn_db: move grn_db_recover() reference to the header file (g…
…roonga#1985) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for c70e7bb - Browse repository at this point
Copy the full SHA c70e7bbView commit details -
docs: api/grn_db: move grn_db_touch() reference to the header file (g…
…roonga#1988) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for f34d9c5 - Browse repository at this point
Copy the full SHA f34d9c5View commit details
Commits on Oct 8, 2024
-
ci macos: temporarily disable mruby test on macos-latest (groonga#1989)
Because there is a rpath issue in Rroonga. Once resolved, we should enable mruby test on macos-latest.
Configuration menu - View commit details
-
Copy full SHA for c39719a - Browse repository at this point
Copy the full SHA c39719aView commit details -
docs: api/grn_db: move grn_db_(create|open) reference to the header f…
…ile (groonga#1990) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 84c6a70 - Browse repository at this point
Copy the full SHA 84c6a70View commit details -
docs: api/grn_search: move grn_obj_search() reference to the header f…
…ile (groonga#1991) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 0437b0d - Browse repository at this point
Copy the full SHA 0437b0dView commit details -
docs: api/grn_db: move grn_obj_db() reference to the header file (gro…
…onga#1992) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 088a1a7 - Browse repository at this point
Copy the full SHA 088a1a7View commit details
Commits on Oct 9, 2024
-
grn_obj_close: do nothing and return GRN_SUCCESS for NULL (groonga#1957)
Generally, functions for release resource do nothing when NULL is specified like "free(NULL)". This changes API but this doesn't break backward compatibility. Because no code exist that use the return value of `grn_obj_close()` when we specify `grn_obj_close(ctx, NULL)` as below. --- Following functions use the return value of `grn_obj_close()`. ``` ./lib/com.c: if (ctx == msg->ctx) { return grn_obj_close(ctx, obj); } ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: rc = grn_obj_close(ctx, obj); ./lib/db.c: return grn_obj_close(ctx, obj); ``` --- `grn_obj_close()` is used in `grn_msg_close()`. However, the return value of `grn_msg_close()` uses no one. ``` % grep -r grn_msg_close ./**/*.c ./lib/com.c:grn_msg_close(grn_ctx *ctx, grn_obj *obj) ./lib/com.c: grn_msg_close(ctx, msg); ./lib/com.c: grn_msg_close(ctx, msg); ./src/grnslap.c: grn_msg_close(ctx, msg); ./src/groonga.c: grn_msg_close(&edge->ctx, msg); ./src/groonga.c: grn_msg_close(ctx, msg); ./src/groonga.c: grn_msg_close(&edge->ctx, obj); ./src/groonga.c: grn_msg_close(ctx, obj); ./src/groonga.c: grn_msg_close(ctx, (grn_obj *)msg); ./src/groonga.c: grn_msg_close(ctx, msg); ./src/groonga.c: grn_msg_close(ctx, msg); ./src/groonga.c: grn_msg_close(ctx, msg); ./src/groonga.c: grn_msg_close(ctx, msg); ./src/groonga.c: grn_msg_close(ctx, msg); ``` --- `grn_obj_close()` is used in `grn_obj_remove_other()`. `grn_obj_remove_other()` is used in `grn_obj_remove_internal()`. `grn_obj_remove_internal()` is used as below. ``` ./lib/db.c: rc = grn_obj_remove_internal(ctx, target, flags); ./lib/db.c: rc = grn_obj_remove_internal(ctx, column, flags); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, 0); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, 0); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, 0); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, 0); ./lib/db.c: rc = grn_obj_remove_internal(ctx, object, flags); ./lib/db.c: rc = grn_obj_remove_internal(ctx, object, flags); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, flags); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, flags); ./lib/db.c: rc = grn_obj_remove_internal(ctx, obj, flags); ``` --- `grn_obj_remove_internal()` is used in `remove_index()`. However, `grn_obj_remove_internal()` is not called when `target` is `NULL` as below. ```c if (!target) { ... } } else if (target->header.type == GRN_COLUMN_INDEX) { // TODO: multicolumn MULTI_COLUMN_INDEXP rc = grn_obj_remove_internal(ctx, target, flags); } ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `remove_columns_raw()` However, `grn_obj_remove_internal()` is not called when `column` is `NULL` as below. ```c if (column) { rc = grn_obj_remove_internal(ctx, column, flags); if (rc != GRN_SUCCESS) { grn_obj_unlink(ctx, column); break; } } ... ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `grn_obj_remove_db_index_columns()`. However, `grn_obj_remove_internal()` is not called when `obj` is `NULL` as below. ```c if (obj && obj->header.type == GRN_COLUMN_INDEX) { rc = grn_obj_remove_internal(ctx, obj, 0); ... } ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `grn_obj_remove_db_reference_columns()`. However, `grn_obj_remove_internal()` is not called when `obj` is `NULL` as below. ```c while ((id = grn_table_cursor_next_inline(ctx, cur)) != GRN_ID_NIL) { grn_obj *obj = grn_ctx_at(ctx, id); grn_obj *range = NULL; if (!obj) { continue; } ... switch (range->header.type) { case GRN_TABLE_NO_KEY: case GRN_TABLE_HASH_KEY: case GRN_TABLE_PAT_KEY: case GRN_TABLE_DAT_KEY: rc = grn_obj_remove_internal(ctx, obj, 0); break; } ... } ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `grn_obj_remove_db_reference_tables()`. However, `grn_obj_remove_internal()` is not called when `obj` is `NULL` as below. ```c while ((id = grn_table_cursor_next_inline(ctx, cur)) != GRN_ID_NIL) { grn_obj *obj = grn_ctx_at(ctx, id); grn_obj *domain = NULL; if (!obj) { continue; } ... switch (domain->header.type) { case GRN_TABLE_NO_KEY: case GRN_TABLE_HASH_KEY: case GRN_TABLE_PAT_KEY: case GRN_TABLE_DAT_KEY: rc = grn_obj_remove_internal(ctx, obj, 0); break; } ... } ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `grn_obj_remove_db_all_tables()` However, `grn_obj_remove_internal()` is not called when `obj` is `NULL` as below. ```c while ((id = grn_table_cursor_next_inline(ctx, cur)) != GRN_ID_NIL) { grn_obj *obj = grn_ctx_at(ctx, id); if (!obj) { continue; } ... switch (obj->header.type) { case GRN_TABLE_NO_KEY: case GRN_TABLE_HASH_KEY: case GRN_TABLE_PAT_KEY: case GRN_TABLE_DAT_KEY: rc = grn_obj_remove_internal(ctx, obj, 0); break; } ... } ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `remove_reference_tables_raw()`. However, `grn_obj_remove_internal()` is not called when `object` is `NULL` as below. ```c object = grn_ctx_at(ctx, id); if (!object) { ... switch (object->header.type) { case GRN_TABLE_HASH_KEY: case GRN_TABLE_PAT_KEY: case GRN_TABLE_DAT_KEY: if (DB_OBJ(object)->id == table_id) { break; } if (object->header.domain == table_id) { rc = grn_obj_remove_internal(ctx, object, flags); is_removed = (grn_table_at(ctx, db, id) == GRN_ID_NIL); } break; ... case GRN_COLUMN_VAR_SIZE: case GRN_COLUMN_FIX_SIZE: if (object->header.domain == table_id) { break; } if (DB_OBJ(object)->range == table_id) { rc = grn_obj_remove_internal(ctx, object, flags); is_removed = (grn_table_at(ctx, db, id) == GRN_ID_NIL); } break; ... } ``` So, this changes API does not affect. --- `grn_obj_remove_internal()` is used in `grn_ctx_remove_by_id_internal()`. However, `grn_obj_remove_internal()` is not called when `obj` is `NULL` as below. ```c if (obj) { grn_rc rc; if (is_top_level) { rc = grn_obj_remove_flags(ctx, obj, flags); } else { rc = grn_obj_remove_internal(ctx, obj, flags); } ... } ``` So, this changes API does not affect. --- `grn_obj_remove_flags()` is used as below. ``` ./lib/db.c: return grn_obj_remove_flags(ctx, obj, 0); ./lib/db.c: return grn_obj_remove_flags(ctx, obj, GRN_OBJ_REMOVE_DEPENDENT); ./lib/db.c: grn_rc rc = grn_obj_remove_flags(ctx, obj, flags); ./lib/db.c: rc = grn_obj_remove_flags(ctx, obj, flags); ``` `grn_obj_remove_flags()` is used in `grn_ctx_remove_by_id_internal()`. However, `grn_obj_remove_flags()` is not called when `obj` is `NULL` as below. ```c if (obj) { grn_rc rc; if (is_top_level) { rc = grn_obj_remove_flags(ctx, obj, flags); } else { rc = grn_obj_remove_internal(ctx, obj, flags); } ... } ``` So, this changes API does not affect. --- `grn_obj_remove_flags()` is used in `grn_obj_remove_dependent()`. However, the return value of `grn_obj_remove_dependent()` uses no one. ``` % grep -r grn_obj_remove_dependent ./**/*.c ./lib/db.c:grn_obj_remove_dependent(grn_ctx *ctx, grn_obj *obj) ``` --- `grn_obj_remove_flags()` is used in `grn_ctx_remove()`. However, `grn_obj_remove_flags()` is not called when `obj` is `NULL` as below. ```c grn_obj *obj = grn_ctx_get(ctx, name, name_size); if (obj) { grn_rc rc = grn_obj_remove_flags(ctx, obj, flags); if (rc == GRN_SUCCESS) { GRN_API_RETURN(rc); } if (!(flags & GRN_OBJ_REMOVE_ENSURE)) { GRN_API_RETURN(rc); } } ... ``` So, this changes API does not affect. --- `grn_obj_remove_flags()` is used in `grn_ctx_remove_by_id_internal()` However, `grn_obj_remove_flags()` is not called when `obj` is `NULL` as below. ```c grn_obj *obj = grn_ctx_at(ctx, id); if (obj) { grn_rc rc; if (is_top_level) { rc = grn_obj_remove_flags(ctx, obj, flags); } else { rc = grn_obj_remove_internal(ctx, obj, flags); } ``` So, this changes API does not affect.
Configuration menu - View commit details
-
Copy full SHA for 6620d73 - Browse repository at this point
Copy the full SHA 6620d73View commit details -
grn_obj_close: check GRN_OBJ_ALLOCATED before grn_bulk_fin()
grn_bulk_fin() may clear header.impl_flags in the future.
Configuration menu - View commit details
-
Copy full SHA for 562aa17 - Browse repository at this point
Copy the full SHA 562aa17View commit details
Commits on Oct 10, 2024
-
docs: api/grn_obj: move grn_obj_clear_lock() reference to the header …
…file (groonga#1994) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 52d4e34 - Browse repository at this point
Copy the full SHA 52d4e34View commit details -
package: windows: Add
vcomp140.dll
to with-vcruntime package (groon……ga#1993) Fix the missing DLL error.
Configuration menu - View commit details
-
Copy full SHA for a9000cb - Browse repository at this point
Copy the full SHA a9000cbView commit details -
docs: api/grn_obj: move grn_obj_is_locked() reference to the header f…
…ile (groonga#1995) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for 9b30275 - Browse repository at this point
Copy the full SHA 9b30275View commit details -
docs: api/grn_proc: move grn_obj_set_finalizer() reference to the hea…
…der file (groonga#1997) GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
Configuration menu - View commit details
-
Copy full SHA for cbe7038 - Browse repository at this point
Copy the full SHA cbe7038View commit details -
docs: clarify differences between grn_obj_unlock() and grn_obj_clear_…
…lock() about lock management (groonga#1996)
Configuration menu - View commit details
-
Copy full SHA for a6df032 - Browse repository at this point
Copy the full SHA a6df032View commit details -
db: return a value of grn_rc type instead of void
Because grn_obj_unlink() may return GRN_INVALID_ARGUMENT when error occurs in this function. Also, grn_obj_close() return a value of grn_rc.
Configuration menu - View commit details
-
Copy full SHA for bd24995 - Browse repository at this point
Copy the full SHA bd24995View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f154ac - Browse repository at this point
Copy the full SHA 2f154acView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee23eb0 - Browse repository at this point
Copy the full SHA ee23eb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c5d496 - Browse repository at this point
Copy the full SHA 0c5d496View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a2a485 - Browse repository at this point
Copy the full SHA 2a2a485View commit details -
Configuration menu - View commit details
-
Copy full SHA for edae2eb - Browse repository at this point
Copy the full SHA edae2ebView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1391e9e - Browse repository at this point
Copy the full SHA 1391e9eView commit details