-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elapsed time checking for PubJoin. #985
Open
ryancrunchi
wants to merge
1
commit into
kolton:master
Choose a base branch
from
ryancrunchi:elapsed-time
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancrunchi
force-pushed
the
elapsed-time
branch
2 times, most recently
from
January 10, 2019 15:48
c7f4d05
to
371972b
Compare
noah-
requested changes
Jan 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code needs overall refactoring and format cleanup
ryancrunchi
force-pushed
the
elapsed-time
branch
3 times, most recently
from
January 22, 2019 16:02
25b121c
to
54f2430
Compare
ryancrunchi
force-pushed
the
elapsed-time
branch
from
January 29, 2019 12:58
54f2430
to
5b44283
Compare
ryancrunchi
force-pushed
the
elapsed-time
branch
from
February 4, 2019 18:45
5b44283
to
30bbc88
Compare
ryancrunchi
force-pushed
the
elapsed-time
branch
from
March 11, 2019 10:08
30bbc88
to
4b2baad
Compare
ryancrunchi
force-pushed
the
elapsed-time
branch
from
April 6, 2019 09:59
4b2baad
to
87830e7
Compare
Added a clickGame function to ControlAction. Added a getGameElapsedTime function to ControlAction. Added a maximum seconds game elapsed check to avoid joining games near end.
I'm new to this but could really use this feature, what's the status? |
Hi, status? This is my #1 feature that I would want. Apart from that, the bot is already great. |
Does this work now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a clickGame function to ControlAction.
Added a getGameElapsedTime function to ControlAction.
Added an optional maximum seconds game elapsed check to avoid joining games near end.