-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add file driver config can be save like the database #566
Open
ljyf5593
wants to merge
1
commit into
kohana:3.3/develop
Choose a base branch
from
ljyf5593:3.3/develop
base: 3.3/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
<?php | ||
/** | ||
* File-based configuration writer. Multiple configuration directories can be | ||
* used by attaching multiple instances of this class to [Kohana_Config]. | ||
* | ||
* @package Kohana | ||
* @category Configuration | ||
* @author Kohana Team | ||
* @copyright (c) 2014 Kohana Team | ||
* @license http://kohanaframework.org/license | ||
*/ | ||
class Kohana_Config_File_Writer extends Kohana_Config_File_Reader implements Kohana_Config_Writer { | ||
|
||
protected $_loaded_keys = array(); | ||
|
||
/** | ||
* Tries to load the specificed configuration group | ||
* | ||
* Returns FALSE if group does not exist or an array if it does | ||
* | ||
* @param string $group Configuration group | ||
* @return boolean|array | ||
*/ | ||
public function load($group) | ||
{ | ||
$config = parent::load($group); | ||
|
||
if ($config !== FALSE) | ||
{ | ||
$this->_loaded_keys[$group] = $config; | ||
} | ||
|
||
return $config; | ||
} | ||
|
||
/** | ||
* Writes the passed config for $group | ||
* | ||
* Returns chainable instance on success | ||
* | ||
* @param string $group The config group | ||
* @param string $key The config key to write to | ||
* @param array $config The configuration to write | ||
* @return boolean | ||
*/ | ||
public function write($group, $key, $config) | ||
{ | ||
$this->_loaded_keys[$group][$key] = $config; | ||
|
||
$config_file = APPPATH.DIRECTORY_SEPARATOR.'config'.DIRECTORY_SEPARATOR.$group.'.php'; | ||
|
||
$result = file_put_contents($config_file, "<?php\nreturn ".var_export($this->_loaded_keys[$group], TRUE).';'); | ||
|
||
return $result !== FALSE; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably check for
is_writable
first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljyf5593 very sorry to come back to you this late. Could you kindly note @shadowhand 's comment here, as I think the sooner we check for
is_writable
the better. And maybe should we add atry... catch
block here for the same reasons?Thanks.