Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file driver config can be save like the database #566

Open
wants to merge 1 commit into
base: 3.3/develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions classes/Kohana/Config/File.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php defined('SYSPATH') OR die('No direct script access.');
/**
* File-based configuration reader. Multiple configuration directories can be
* File-based configuration writer. Multiple configuration directories can be
* used by attaching multiple instances of this class to [Config].
*
* @package Kohana
Expand All @@ -9,7 +9,7 @@
* @copyright (c) 2009-2012 Kohana Team
* @license http://kohanaframework.org/license
*/
class Kohana_Config_File extends Kohana_Config_File_Reader
class Kohana_Config_File extends Kohana_Config_File_Writer
{
// @see Kohana_Config_File_Reader
// @see Kohana_Config_File_Writer
}
56 changes: 56 additions & 0 deletions classes/Kohana/Config/File/Writer.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<?php
/**
* File-based configuration writer. Multiple configuration directories can be
* used by attaching multiple instances of this class to [Kohana_Config].
*
* @package Kohana
* @category Configuration
* @author Kohana Team
* @copyright (c) 2014 Kohana Team
* @license http://kohanaframework.org/license
*/
class Kohana_Config_File_Writer extends Kohana_Config_File_Reader implements Kohana_Config_Writer {

protected $_loaded_keys = array();

/**
* Tries to load the specificed configuration group
*
* Returns FALSE if group does not exist or an array if it does
*
* @param string $group Configuration group
* @return boolean|array
*/
public function load($group)
{
$config = parent::load($group);

if ($config !== FALSE)
{
$this->_loaded_keys[$group] = $config;
}

return $config;
}

/**
* Writes the passed config for $group
*
* Returns chainable instance on success
*
* @param string $group The config group
* @param string $key The config key to write to
* @param array $config The configuration to write
* @return boolean
*/
public function write($group, $key, $config)
{
$this->_loaded_keys[$group][$key] = $config;

$config_file = APPPATH.DIRECTORY_SEPARATOR.'config'.DIRECTORY_SEPARATOR.$group.'.php';

$result = file_put_contents($config_file, "<?php\nreturn ".var_export($this->_loaded_keys[$group], TRUE).';');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably check for is_writable first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljyf5593 very sorry to come back to you this late. Could you kindly note @shadowhand 's comment here, as I think the sooner we check for is_writable the better. And maybe should we add a try... catch block here for the same reasons?

Thanks.


return $result !== FALSE;
}
}