Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch #440

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Elasticsearch #440

merged 4 commits into from
Oct 11, 2024

Conversation

rakesh-jain
Copy link
Contributor

No description provided.

kmgowda
kmgowda requested changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@kmgowda kmgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding elastic search driver ; but there are review comments to address ; please fix them all

drivers/elasticsearch/src/main/java/io/sbk/driver/Elasticsearch/ElasticsearchReader.java Outdated Show resolved Hide resolved
drivers/elasticsearch/src/main/java/io/sbk/driver/Elasticsearch/ElasticsearchWriter.java Outdated Show resolved Hide resolved
drivers/elasticsearch/src/main/java/io/sbk/driver/Elasticsearch/Elasticsearch.java Outdated Show resolved Hide resolved
drivers/elasticsearch/src/main/java/io/sbk/driver/Elasticsearch/Elasticsearch.java Outdated Show resolved Hide resolved
@kmgowda kmgowda merged commit 326fdea into kmgowda:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmgowda kmgowda kmgowda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakesh-jain @kmgowda