fix: fix multiplicity to handle dummy rows in LogUp

kkrt-labs · Dec 2, 2024 · 7c07c4c · 7c07c4c
1 parent a73c9c3
commit 7c07c4c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/crates/brainfuck_prover/src/components/memory/component.rs b/crates/brainfuck_prover/src/components/memory/component.rs
@@ -97,12 +97,13 @@ impl FrameworkEval for MemoryEval {
         eval.add_constraint(d.clone() * (next_mp - mp.clone()));
 
         // If `d` is set, then `mv` remains the same
-        eval.add_constraint(d * (next_mv - mv.clone()));
+        eval.add_constraint(d.clone() * (next_mv - mv.clone()));
 
         // LogUp of `clk`, `mp` and `mv`
+        let multiplicity = E::EF::from(d) - E::EF::one();
         eval.add_to_relation(&[RelationEntry::new(
             &self.memory_lookup_elements,
-            -E::EF::one(),
+            multiplicity,
             &[clk, mp, mv],
         )]);