Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip all ef tests #853

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Dec 13, 2023

Just a PR to run all ef tests


This change is Reviewable

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.66%. Comparing base (05445f7) to head (b5db3a5).
Report is 88 commits behind head on main.

❗ Current head b5db3a5 differs from pull request most recent head d18fae8. Consider uploading reports for the commit d18fae8 to get more accurate results

Files Patch % Lines
src/kakarot/errors.cairo 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   77.41%   70.66%   -6.76%     
==========================================
  Files          25       48      +23     
  Lines        2227     5089    +2862     
==========================================
+ Hits         1724     3596    +1872     
- Misses        503     1493     +990     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter force-pushed the cw/run-all branch 2 times, most recently from 4cbdd9a to b5db3a5 Compare January 8, 2024 07:49
@kkrt-labs kkrt-labs deleted a comment Jan 8, 2024
@ClementWalter ClementWalter force-pushed the cw/run-all branch 5 times, most recently from 94b5b9b to 74f887b Compare January 22, 2024 09:14
@ClementWalter ClementWalter force-pushed the cw/run-all branch 2 times, most recently from 232673f to 654e253 Compare February 1, 2024 15:23
@enitrat enitrat force-pushed the cw/run-all branch 3 times, most recently from 1c5d516 to 756c5e0 Compare February 14, 2024 18:58
@enitrat enitrat force-pushed the cw/run-all branch 2 times, most recently from 3b91e1b to be02a55 Compare March 6, 2024 17:42
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* fix: use real basefee in fee history

* fix: fix docker compose

* fix pr comments

* saturating add and sub

* add comment:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants