Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-109] [KGA-137] fix: validate s <= N//2 when recovering tx sender #1635

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 22, 2024

Copy link

Copy link

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (204b3d7) to head (1a628f6).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1635     +/-   ##
=======================================
- Coverage   64.0%   63.8%   -0.2%     
=======================================
  Files         44      44             
  Lines       8331    8347     +16     
=======================================
- Hits        5336    5332      -4     
- Misses      2995    3015     +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@enitrat enitrat requested review from obatirou and ClementWalter and removed request for obatirou November 22, 2024 08:31
@obatirou obatirou changed the title [KGA-109] [KGA-137] fix: validate N//2 < s when recovering tx sender [KGA-109] [KGA-137] fix: validate s < N//2 when recovering tx sender Nov 25, 2024
@obatirou obatirou changed the title [KGA-109] [KGA-137] fix: validate s < N//2 when recovering tx sender [KGA-109] [KGA-137] fix: validate s <= N//2 when recovering tx sender Nov 25, 2024
@obatirou obatirou merged commit 2959ece into main Nov 25, 2024
16 checks passed
@obatirou obatirou deleted the fix/malleable-s-tx-signature branch November 25, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants