Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-98] QA report 66 #1633

Merged
merged 5 commits into from
Nov 25, 2024
Merged

[KGA-98] QA report 66 #1633

merged 5 commits into from
Nov 25, 2024

Conversation

obatirou
Copy link
Collaborator

https://github.com/code-423n4/2024-09-kakarot-findings/issues/66

  • Missing boundary check in EVM transaction decoding
    adds a check to ensure [call_array].data_offset + [call_array].data_len <= calldata_len
  • Several of the stack_size_diff values defined in constants.cairo are off
    put the right values
  • After Kakarot's native token is changed, an approval from account_contract instances can't be re-triggered
    remove the setter, this will not change
  • Some invalid values for the v field in Ethereum signatures are accepted
    add a check to ensure y_parity is 0 or 1

Copy link

QA Report

@obatirou obatirou marked this pull request as ready for review November 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants