[KGA-101] Qa report 128 (#1636)

code-423n4/2024-09-kakarot-findings#128
kkrt-labs · Nov 25, 2024 · a8072d8 · a8072d8
1 parent 0e61ea9
commit a8072d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cairo_zero/kakarot/precompiles/precompiles.cairo b/cairo_zero/kakarot/precompiles/precompiles.cairo
@@ -243,10 +243,6 @@ namespace Precompiles {
     ) {
         alloc_locals;
         let (implementation) = Kakarot_cairo1_helpers_class_hash.read();
-        let (calldata: felt*) = alloc();
-        assert [calldata] = evm_address;
-        assert [calldata + 1] = input_len;
-        memcpy(calldata + 2, input, input_len);
         let (
             success, gas, return_data_len, return_data
         ) = ICairo1Helpers.library_call_exec_precompile(

diff --git a/cairo_zero/kakarot/state.cairo b/cairo_zero/kakarot/state.cairo
@@ -389,6 +389,10 @@ namespace State {
             [recipient.balance], transfer.amount
         );
 
+        if (carry != 0) {
+            return 0;
+        }
+
         let sender = Account.set_balance(sender, &sender_balance_new);
         let recipient = Account.set_balance(recipient, &recipient_balance_new);