Fix incorrect directory path Update extract_abi.sh #1539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have made a correction in the build script located in
build.sh
. There was an error in the line that constructs the paths for creating subdirectories.Issue:
In the original line:
${dest_dir}
and${build_dir}
were concatenated without a slash, which could lead to incorrect paths if theroot_dir
,dest_dir
, orbuild_dir
contain relative paths.Solution:
I replaced the line with the following:
${root_dir}
and${dest_dir}
and${build_dir}
.Why is this change important?
This fix is crucial to ensure that the paths constructed for creating subdirectories are formatted correctly, especially when using relative paths. Without this correction, the script might lead to errors or unexpected behavior when creating the necessary directories for the build process.
Pull Request Details
build.sh
By merging this change, we will prevent any issues related to incorrect paths during the build process.
I hope this pull request is clear and helps improve the robustness of the build script! Let me know if anything needs to be adjusted.
This PR is ready to be reviewed and merged.
This version is well-structured, clearly explains the mistake, and emphasizes the importance of the fix.
Please check the type of change your PR introduces:
Does this introduce a breaking change?