ci: karnot deployment #1484
Merged
ci: karnot deployment #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
force-pushed
the
ci/update-karnot-deployment
branch
from
5a8da99
to
08f6167
Compare
greged93
force-pushed
the
ci/update-karnot-deployment
branch
5 times, most recently
from
94d07f4
to
ce43690
Compare
Eikix
reviewed
Oct 24, 2024
Eikix
reviewed
Oct 24, 2024
Eikix
reviewed
Oct 24, 2024
tcoratger
previously approved these changes
Oct 24, 2024
Eikix
reviewed
Oct 24, 2024
greged93
commented
Oct 24, 2024
Eikix
previously approved these changes
Oct 24, 2024
|
I tried by merging on my fork in main and running the CI there, which worked, but I didn't check if the env vars were correct, let me quickly do it now |
greged93
force-pushed
the
ci/update-karnot-deployment
branch
from
531e55c
to
a544126
Compare
|
@Eikix tried doing the nicer formatting but apparently this gets interpreted as an array on Karnot's side so it doesn't work |
they can't fix it in a later version? |
|
@anukkrit149 is it possible to have the nicer formatting in any way or not? |
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
greged93
force-pushed
the
ci/update-karnot-deployment
branch
from
a544126
to
14d08b1
Compare
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
tcoratger
previously approved these changes
Oct 25, 2024
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
…ed93/kakarot-rpc into ci/update-karnot-deployment
tcoratger
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 4 hours
Resolves: #NA
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Update the Karnot CI to the correct values + some formatting.
Does this introduce a breaking change?