[Enhancement] Optimize CairoLib Functions by Overloading with calldata for Gas Efficiency
#11
Conversation
| return callCairo(call.contractAddress, call.functionSelector, call.data); | ||
| } | ||
|
|
||
| function callCairo(uint256 contractAddress, uint256 functionSelector) internal returns (bytes memory) { | ||
| uint256[] memory data = new uint256[](0); | ||
| return callCairo(contractAddress, functionSelector, data); | ||
| return callCairo(contractAddress, functionSelector); |
There was a problem hiding this comment.
I am not sure this can work: it would call itself recursively.
You would need to pass the data as the actual function overloaded has a third parameter.
| @@ -19,7 +19,7 @@ library CairoLib { | |||
| /// @param functionSelector The function selector of the Cairo contract function to be called. | |||
There was a problem hiding this comment.
As a general comment: you need to keep the memory version of the functions as most of the library is used inside a contract that would do some processing on the input data.
The code is in contradiction with your PR description as the memory version are removed
Backward Compatibility: The original functions with memory parameters are retained to prevent breaking existing integrations.
I think use cases need to be shown: this should to be done in sync with end-to-end tests in the kakarot repo to ensure the usage is relevant and functional. For now, all use case need preprocessing on input hence using calldata is not possible.
You can look at how this library is used in the following PRs.
There was a problem hiding this comment.
Alright, I will look more into that.
Summary
This pull request introduces optimizations to the
CairoLib.sollibrary by overloading functions to acceptcalldataparameters instead ofmemory. These changes aim to enhance gas efficiency when interacting with Cairo contracts on Starknet.Changes Introduced
Function Overloading with
calldata:callCairo,staticcallCairo, andmulticallCairofunctions that acceptcalldataparameters.memoryparameter functions to ensure backward compatibility.Code Adjustments:
abi.encode) to handle bothmemoryandcalldatainputs effectively.Rationale
Overloading functions with
calldataparameters can lead to significant gas savings by eliminating unnecessary data copying into memory, especially for functions that do not modify input data. This optimization aligns with the feature request outlined in #8 and enhances the efficiency of interactions between Solidity and Cairo contracts.Considerations
memoryparameters are retained to prevent breaking existing integrations.stringdata locations to prevent compiler resolution issues.Related Issue #8
Additional Notes
I understand that this contribution was not explicitly requested. However, considering the nature of the issue and the potential benefits of the proposed optimizations, I wanted to offer this solution. I'm open to feedback and willing to make further adjustments to better align with the project's goals and standards.
Please feel free to review the changes and let me know if there are any areas that require modification or additional testing. I'm eager to contribute and support the project's development in any way I can.
Checklist
Thank you for considering my contribution!