Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests failing due to missing field gasPrice #458

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add tests failing due to missing field gasPrice #458

merged 1 commit into from
Oct 2, 2023

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Sep 30, 2023

Time spent on this PR: 10m

#454 #456 #457

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

danilowhk
danilowhk approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@danilowhk danilowhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@danilowhk danilowhk added this pull request to the merge queue Oct 2, 2023
Merged via the queue into kkrt-labs:main with commit 2b39e40 Oct 2, 2023
4 checks passed
@khaeljy khaeljy deleted the add-missing-field-gasPrice-tests branch October 2, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilowhk danilowhk danilowhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaeljy @danilowhk