Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stRandom and stRandom2 testsuites #399

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Sep 29, 2023

Time spent on this PR: 1h

#387 #388

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@khaeljy
Copy link
Contributor Author

khaeljy commented Sep 30, 2023

I don't understand why the tests fail, it works fine on my local workstation (commenting on the stMemoryStressTest testsuite, as I don't have enough RAM).

@Eikix
Copy link
Member

Eikix commented Oct 2, 2023

I tried to run the tests in debug mode, but they don't give a reason why the tests are failing.
I'll try to increase the size of the runner and observe the results.

Let's first merge all PRs in the backlog and then try to do that

@greged93
Copy link
Contributor

greged93 commented Oct 9, 2023

Any update on this?

@Eikix
Copy link
Member

Eikix commented Oct 9, 2023

Any update on this?

Trying to increase size of runner

@greged93
Copy link
Contributor

greged93 commented Oct 9, 2023

Looks like it's missing some skipped tests @khaeljy can you maybe take a look at this and update the tests that need to be skipped?

@khaeljy
Copy link
Contributor Author

khaeljy commented Oct 9, 2023

Looks like it's missing some skipped tests @khaeljy can you maybe take a look at this and update the tests that need to be skipped?

It's strange, maybe it's due to a rebase.
I'll look into it as soon as possible.

@khaeljy
Copy link
Contributor Author

khaeljy commented Oct 9, 2023

Looks like it's missing some skipped tests @khaeljy can you maybe take a look at this and update the tests that need to be skipped?

Done!

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm gg

@Eikix Eikix added this pull request to the merge queue Oct 10, 2023
Merged via the queue into kkrt-labs:main with commit c1c741b Oct 10, 2023
3 checks passed
@khaeljy khaeljy deleted the stRandom-stRandom2 branch October 11, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants