Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stChainId to the blockchain tests module #300

Merged
merged 3 commits into from
Sep 27, 2023
Merged

feat: add stChainId to the blockchain tests module #300

merged 3 commits into from
Sep 27, 2023

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Sep 26, 2023 •
edited
Loading

Time spent on this PR: 10m

#92

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

danilowhk
danilowhk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@danilowhk danilowhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@danilowhk danilowhk added this pull request to the merge queue Sep 27, 2023
Merged via the queue into kkrt-labs:main with commit cb8161e Sep 27, 2023
4 checks passed
@khaeljy khaeljy deleted the khaeljy/issue92 branch September 27, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

@danilowhk danilowhk danilowhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaeljy @danilowhk @Eikix