Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes NewClient definition and removes bloated interface #32

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

kislerdm
Copy link
Owner

What changed

  • Removed Client interfaces
  • Removed variadic variables
  • Added Config as the main argument of NewClient to configure SDK
  • Minor refactoring:
    • errors moved to error.go
    • mock renamed to mockhttp

Why do we need it

  • Simplification: no interfaces bloating
  • Ease of stubbing/mocking

Signed-off-by: Dmitry Kisler <admin@dkisler.com>
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #32 (74559cc) into master (d1b56b2) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   93.48%   93.10%   -0.39%     
==========================================
  Files           2        3       +1     
  Lines         430      406      -24     
==========================================
- Hits          402      378      -24     
  Misses         21       21              
  Partials        7        7              
Files Coverage Δ
error.go 100.00% <100.00%> (ø)
mockhttp.go 76.31% <ø> (ø)
sdk.go 96.62% <100.00%> (-0.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kislerdm kislerdm merged commit 5e321f1 into master Oct 26, 2023
6 of 7 checks passed
@kislerdm kislerdm deleted the chore/v0.3.0 branch October 26, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant