-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple audiences #44
Conversation
@peterphanouvong, I'd suggest instead of doing a string split convert the property So for
Then check later if it is an array or not. Could be a condition or do something to make an array if not like:
|
@coel I guess a lot of the time the audience is being passed in via a
and then having to do some nastiness to convert that environment variable string into an array? |
@DaveOrDead , I think if it is nasty we shouldn't force it onto users in the base SDK. It seems like whitespace is valid in an audience, though we don't seem to handle it. We might need to patch that up. If we have helpers to deal with .env I think it should happen in the layer .env is introduced. |
@coel I'm ok with that @peterphanouvong are you ok to update? |
Explain your changes
Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.