Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use state if existing in session #43

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Use state if existing in session #43

merged 1 commit into from
Jan 15, 2024

Conversation

coel
Copy link
Member

@coel coel commented Jan 15, 2024

Explain your changes

When generating multiple links, the state of earlier links are overridden so do not successfully complete login on callback. Specifically, where login is started in multiple tabs, only the last one can be used successfully to login. These changes reuse state until successful login, so any of the tabs can be used to login.

Note: After login, the remaining tabs will still not be able to be used for login. The state can still be passed in if a new state is preferred on every call.

Alternative solution to: #40

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

@coel coel requested a review from DaveOrDead January 15, 2024 00:34
@DaveOrDead DaveOrDead merged commit e39d549 into main Jan 15, 2024
1 check passed
@DaveOrDead DaveOrDead deleted the leo/same_state branch January 15, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants