Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few sexy UI stuff:3 #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Yvtq8K3n
Copy link

Hope you like it:D I gave a bit of test and if you delete all tiles and try move the switch/comboBox the program will crash(that was already happening from the previous, implementation)

@kimwnasptd
Copy link
Owner

Hey there @Yvtq8K3n, thanks your contribution. I haven't looked at the project for a long time so it is not immediately clear to me what those changes try to fix.

I can see you've done 3 commits and all of them seem to make significant changes. Could you open three issues in this repo, one for each commit? It would be helpful if for each one you could provide info about what the original problem was and how you propose to fix it

Then we can discuss each one separately and decide which parts to merge.

@Yvtq8K3n
Copy link
Author

Yvtq8K3n commented Jun 2, 2019

Hi, i no longer have the project. Create a new branch and test it. Only adds a slider and multiselection(like on Windows folders when u use ctrl and click then) .

@kimwnasptd
Copy link
Owner

Just checked the changes from your fork. The multi selection is really nice!

I have a small nit about the slider. Its about the Tab Order.
The default UX I have in mind when viewing the OWs is :

  • The user navigates with the up/down arrow keys the OWs in an OW Table
  • The user clicks tab and the selection goes to the frames selector

This way the user can easily with just one click scan the frames of a selected OW. In this PR the Tab Order seems different and when pressing tab from the Table/OW selector then the focus doesn't go to the frames.

Could you just edit the Tab Order and make the Frame Selector to be the next one from the OW Table? Other than that we can merge the PR.

@Yvtq8K3n
Copy link
Author

I will check those changes once i have time, in other words 1 month:3 Exams and stuff now, lel.

@kimwnasptd
Copy link
Owner

That's when I would also have time to review due to our exams :P

@Yvtq8K3n
Copy link
Author

Hey sorry i kind of went busy. Do you still want me to apply thoose changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants