-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Loopback Integrations #19
Open
zeerobug
wants to merge
11
commits into
kimkha:master
Choose a base branch
from
zeerobug:react-admin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified Readme to replace admin-on-rest (discontinued) by react-admin Modified Readme to describe the function to implement in loopback to make it work
Thank you for your hard work and PR. I have a question: why don't you just use default I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want. |
Hi,
You are right, we have to keep it simple, I just copied and paste my function. I use customer because I needed to extend the default model.
Please modify the README as you wish.
Cheers,
Thomas
… On 10 Jul 2018, at 17:23, Nguyễn Kim Kha ***@***.***> wrote:
Thank you for your hard work and PR.
I have a question: why don't you just use default User model for authentication? Why must you create new model called Customer on your Loopback?
I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASTa9fEMi5fvY1ksShWiL7MkO8wB9aNGks5uFMbjgaJpZM4VJC4r>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kimkha,
This is a fork for:
AUTH_GET_PERMISSIONS
caseThere is a pending TODO to integrate Loopback side functions as hooks, which I can't do right now.
Thank you for your work !