Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Loopback Integrations #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

zeerobug
Copy link

Hi Kimkha,

This is a fork for:

  • Modified authClient to integrate AUTH_GET_PERMISSIONS case
  • Added DELETE_MANY case for full compatibility with react-admin list view
  • Added UPDATE_MANY (untested)
    There is a pending TODO to integrate Loopback side functions as hooks, which I can't do right now.

Thank you for your work !

Thomas and others added 9 commits June 23, 2018 11:14
@kimkha
Copy link
Owner

kimkha commented Jul 10, 2018

Thank you for your hard work and PR.

I have a question: why don't you just use default User model for authentication? Why must you create new model called Customer on your Loopback?

I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want.

@zeerobug
Copy link
Author

zeerobug commented Jul 11, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants