Add HTTP/2, QUIC, VPN and Self-Signed CA support #464
Conversation
|
|
GGG-KILLER
force-pushed
the
all-http-through-cronet-cupertino
branch
from
0a86d8a
to
38dc6ac
Compare
| if (Platform.isAndroid || Platform.isIOS || Platform.isMacOS) { | ||
| dio.httpClientAdapter = newNativeAdapter(); |
There was a problem hiding this comment.
There shouldn't be any issues to just using the native methods since it's technically what the browsers use, so we'd just be doing requests in the same way a browser does, however it'd be nice to have some more testing on this front.
There was a problem hiding this comment.
I've tested gelbooru, gelbooru_v2, shimmie2, anime-pictures and danbooru.
They're all working on Android. It'd be nice to be able to get some tests on iOS/MacOS.
| final booru = booruFactory.getBooruFromUrl(baseUrl) ?? | ||
| booruFactory.getBooruFromId(booruConfig.booruId); |
There was a problem hiding this comment.
This is needed because otherwise no booru is selected when coming from the "add new booru" page and an unknown URL is used, even though the user has told which booru it is.
There was a problem hiding this comment.
It works fine on my end. Are you sure this is an issue?
There was a problem hiding this comment.
Yes, this is an issue when using boorus that don't have known URLs, in my case I have https://booru.shiro.lan/, that I tried to add as Danbooru, and when it tries to test it, booru is null because it tries to get the booru type from the URL, not from what was selected in the dropdown.
There was a problem hiding this comment.
Please merge the latest changes from dev and see if the issue is still there.
GGG-KILLER
changed the title
| enableBrotli: true, | ||
| enableHttp2: true, | ||
| enableQuic: true, | ||
| ), |
There was a problem hiding this comment.
need to add our custom User-Agent
There was a problem hiding this comment.
Seems like error states are not handled correctly here, you can try adding https://www.zerochan.net/ WITHOUT a custom user-agent and see it yourself.
An error placeholder should be displayed whenever there are issues loading the image
This PR basically makes it so that all requests go through
package:cronet_http(on Android) orpackage:cupertino_http(on MacOS/iOS) usingpackage:native_dio_adapter.From the
package:native_dio_adapterpage:This enables us in the future to add support for blocking image loading outside of WiFi or metered connections, however I did not want to do more than needed in this PR.
This PR also changes the security settings for the app to allow user-added/user-installed CAs so that people can access their own self-hosted boorus that use self-signed certificates.
Fixes #463.