Ensure languages are loaded before rendering forms #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinchappell
approved these changes
Nov 13, 2024
| @@ -197,6 +198,11 @@ class FormRender { | |||
| } | |||
| } | |||
|
|
|||
| if (this.mi18nLoading) { | |||
| await this.mi18nLoading | |||
|
Don't merge this until tests are modified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1577
The language files are loaded async, however they are expected to be loaded by formRender prior to rendering of any controls.
This has a BC break in that the formRender:render() method is now async and therefore may not have completed if there are post render calls. You can see the effect in the failed tests