feat(HardwareDetails page): add CommitNavigationGraph to all tabs #610

lfjnascimento · 2024-11-26T18:50:14Z

refactor: make CommitNavigationGraph route-agnostic
fix: commit history should be counted from the head backwards
feat: add filter by commit hash in hardwareDetails endpoint
feat: add CommitNavigationGraph to HardwareDetails tabs
feat: increase tree selection debounce to 2s
feat: the hardwareDetails endpoint only need a limit time

Close #477

How To test:

Go to any HardwareDetails page
Let just one three selected
Navigate to the commit history using the CommitNavigationGraph

Note: the status count is not correct for the builds tab, this is because of the way that the endpoint commitHistory currently works. We have issue #601 to fix this, which will be resolved soon

WilsonNet · 2024-11-27T16:36:38Z

please update the httpie request file with a request with a different head commit so we can now how the payload is supposed to be

WilsonNet · 2024-11-27T17:07:53Z

dashboard/src/api/hardwareDetails.ts

+  treeCommits: TTreeCommits,
+): Record<string, string> => {
+  const selectedTrees: Record<string, string> = {};
+
+  selectedIndexes.forEach(idx => {
+    const key = idx.toString();
+    const value = treeCommits
+      ? treeCommits[key] || TREE_SELECT_HEAD_VALUE
+      : TREE_SELECT_HEAD_VALUE;
+
+    selectedTrees[key] = value;
+  });
+
+  return selectedTrees;


Suggested change

treeCommits: TTreeCommits,

): Record<string, string> => {

const selectedTrees: Record<string, string> = {};

selectedIndexes.forEach(idx => {

const key = idx.toString();

const value = treeCommits

? treeCommits[key] || TREE_SELECT_HEAD_VALUE

: TREE_SELECT_HEAD_VALUE;

selectedTrees[key] = value;

});

return selectedTrees;

treeCommits: TTreeCommits = {},

): Record<string, string> => {

const selectedTrees: Record<string, string> = {};

selectedIndexes.forEach(idx => {

const key = idx.toString();

const value = treeCommits[idx] || TREE_SELECT_HEAD_VALUE;

selectedTrees[key] = value;

});

return selectedTrees;

WilsonNet · 2024-11-27T17:13:33Z

dashboard/src/pages/TreeDetails/Tabs/Boots/BootsTab.tsx

@@ -24,6 +23,8 @@ import MemoizedIssuesList from '@/components/Cards/IssuesList';
 import MemoizedHardwareTested from '@/components/Cards/HardwareTested';
 import type { TestsTableFilter } from '@/types/tree/TreeDetails';

+import TreeCommitNavigationGraph from '../TreeCommitNavigationGraph';


relative import, we need the linter rule

I thought we would use relative import when getting from the parent directory, I'll change it

WilsonNet · 2024-11-27T17:14:09Z

dashboard/src/pages/TreeDetails/Tabs/Build/BuildTab.tsx

@@ -26,6 +25,8 @@ import MemoizedIssuesList from '@/components/Cards/IssuesList';

 import { DesktopGrid, InnerMobileGrid, MobileGrid } from '../TabGrid';

+import TreeCommitNavigationGraph from '../TreeCommitNavigationGraph';


relative import

WilsonNet · 2024-11-27T17:15:36Z

dashboard/src/pages/TreeDetails/Tabs/Tests/TestsTab.tsx

@@ -27,6 +26,8 @@ import MemoizedHardwareTested from '@/components/Cards/HardwareTested';

 import { TestsTable } from '@/components/TestsTable/TestsTable';

+import TreeCommitNavigationGraph from '../TreeCommitNavigationGraph';


relative import

WilsonNet · 2024-11-27T17:18:00Z

dashboard/src/pages/hardwareDetails/Tabs/Boots/BootsTab.tsx

@@ -35,9 +35,11 @@ import type { ArchCompilerStatus } from '@/types/general';

 import FilterLink from '../../HardwareDetailsFilterLink';
 import { MemoizedSummaryItem } from '../Build/BuildTab';
+import HardwareCommitNavigationGraph from '../HardwareCommitNavigationGraph';


relative import

WilsonNet · 2024-11-27T17:19:31Z

dashboard/src/pages/hardwareDetails/Tabs/HardwareCommitNavigationGraph.tsx

+      gitBranch={tree.gitRepositoryBranch || ''}
+      gitUrl={tree.gitRepositoryUrl || ''}
+      treeId={treeId || ''}
+      headCommitHash={tree.headGitCommitHash || ''}


Don't give fake news to the component, let the component deal with the undefined

WilsonNet · 2024-11-27T17:21:01Z

dashboard/src/components/CommitNavigationGraph/CommitNavigationGraph.tsx

+  diffFilter: TFilter;
+  gitUrl: string;
+  gitBranch: string;
+  headCommitHash: string;


Make things that can be undefined optional here

WilsonNet · 2024-11-27T17:58:11Z

backend/kernelCI_app/views/hardwareDetailsView.py

+        commit_hashes = [tree["git_commit_hash"] for tree in trees]
+        qFilter = Q(build__checkout__start_time__gte=start_datetime)
+        qFilter &= Q(build__checkout__start_time__lte=end_datetime)
+        qFilter |= Q(build__checkout__git_commit_hash__in=commit_hashes)


I don't know if this comment went trough because it disappeared, but I don't think we need to filter with timestamps here since we already have the commit hashes

yes I notice that and I'm removing it right now

WilsonNet

pre approving it

MarceloRobert

There are some trees which seem to not be defaulted to its head, such as here

dashboard/src/components/CommitNavigationGraph/CommitNavigationGraph.tsx

dashboard/src/pages/Hardware/HardwareTable.tsx

Part of #477

now we can select choose the threes and select a specif commit of the tree Part of #477

close #477

- The endpoint just need to use a limit time, there is no need to use a start time

MarceloRobert

Working well on my tests

lfjnascimento self-assigned this Nov 26, 2024

lfjnascimento force-pushed the feat/HD_commit_graph2 branch from 3513234 to a547893 Compare November 27, 2024 17:00

WilsonNet reviewed Nov 27, 2024

View reviewed changes

lfjnascimento force-pushed the feat/HD_commit_graph2 branch 2 times, most recently from b6026fd to f990c39 Compare November 27, 2024 17:53

WilsonNet reviewed Nov 27, 2024

View reviewed changes

WilsonNet approved these changes Nov 27, 2024

View reviewed changes

MarceloRobert reviewed Nov 27, 2024

View reviewed changes

dashboard/src/components/CommitNavigationGraph/CommitNavigationGraph.tsx Outdated Show resolved Hide resolved

dashboard/src/pages/Hardware/HardwareTable.tsx Outdated Show resolved Hide resolved

lfjnascimento added 6 commits November 27, 2024 20:23

refactor: make CommitNavigationGraph route-agnostic

e7e08f8

Part of #477

fix: commit history should be counted from the head backwards

a5719e0

feat: add filter by commit hash in hardwareDetails endpoint

35e23fa

now we can select choose the threes and select a specif commit of the tree Part of #477

feat: add CommitNavigationGraph to HardwareDetails tabs

f28fc4a

close #477

feat: increase tree selection debounce to 2s

bbb0be5

feat: the hardwareDetails endpoint only need a limit time

79af132

- The endpoint just need to use a limit time, there is no need to use a start time

lfjnascimento force-pushed the feat/HD_commit_graph2 branch from 0a07989 to 79af132 Compare November 28, 2024 11:07

MarceloRobert approved these changes Nov 28, 2024

View reviewed changes

lfjnascimento merged commit 79af132 into main Nov 28, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(HardwareDetails page): add CommitNavigationGraph to all tabs #610

feat(HardwareDetails page): add CommitNavigationGraph to all tabs #610

lfjnascimento commented Nov 26, 2024 •

edited

Loading

WilsonNet commented Nov 27, 2024

WilsonNet Nov 27, 2024 •

edited

Loading

WilsonNet Nov 27, 2024

lfjnascimento Nov 27, 2024

WilsonNet Nov 27, 2024

WilsonNet Nov 27, 2024

WilsonNet Nov 27, 2024

WilsonNet Nov 27, 2024

WilsonNet Nov 27, 2024

lfjnascimento Nov 27, 2024

WilsonNet Nov 27, 2024

lfjnascimento Nov 27, 2024

WilsonNet left a comment

MarceloRobert left a comment

MarceloRobert left a comment

		@@ -26,6 +25,8 @@ import MemoizedIssuesList from '@/components/Cards/IssuesList';

		import { DesktopGrid, InnerMobileGrid, MobileGrid } from '../TabGrid';

		import TreeCommitNavigationGraph from '../TreeCommitNavigationGraph';

		@@ -27,6 +26,8 @@ import MemoizedHardwareTested from '@/components/Cards/HardwareTested';

		import { TestsTable } from '@/components/TestsTable/TestsTable';

		import TreeCommitNavigationGraph from '../TreeCommitNavigationGraph';

feat(HardwareDetails page): add CommitNavigationGraph to all tabs #610

feat(HardwareDetails page): add CommitNavigationGraph to all tabs #610

Conversation

lfjnascimento commented Nov 26, 2024 • edited Loading

How To test:

WilsonNet commented Nov 27, 2024

WilsonNet Nov 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WilsonNet left a comment

Choose a reason for hiding this comment

MarceloRobert left a comment

Choose a reason for hiding this comment

MarceloRobert left a comment

Choose a reason for hiding this comment

lfjnascimento commented Nov 26, 2024 •

edited

Loading

WilsonNet Nov 27, 2024 •

edited

Loading