-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the create starknet account logic for Kotlin #76
Adding the create starknet account logic for Kotlin #76
Conversation
Android is blocking http. You can try using a provider like alchemy, which will give you a free https starknet rpc for the time being. Alternatively you can add the katana url as an allowed url by following option 2b in this guide: https://www.geeksforgeeks.org/android-cleartext-http-traffic-not-permitted/ , or just allow all http traffic with option 1b. However we dont want to commit 1b. |
Got it. I already did all that stuff. But still not working. Maybe I should change the RPC, do you have that RPC from Alchemy or how can I get that? Really weird that still not working. I have Katana running on the background. |
@Gerson2102 Looks good, can you take a look at the conflicts please? |
ee2ef14
to
a96ee3a
Compare
@@ -65,6 +65,10 @@ android { | |||
} | |||
dependencies { | |||
|
|||
implementation("com.swmansion.starknet:starknet:0.12.1@aar"){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a duplicate, either remove this or line 100.
Other than change i requested this is a good start. Will merge once that is addressed |
actually i will just merge and then remove it. |
Thanks, yesterday I was deleting that dependency but for a reason I couldn't run the app again. And I was trying again today and same story. @trbutler4 |
Adding the create starknet account logic for Kotlin. I have an error currently. I will give more details inside of the PR.