Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor aws_kinesis_stream_scaler #6400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor aws_kinesis_stream_scaler #6400

wants to merge 1 commit into from

Conversation

omerap12
Copy link
Contributor

@omerap12 omerap12 commented Dec 2, 2024

Refactor aws kinesis stream scaler configuration

Checklist

Fixes #5797

Relates to #

@omerap12
refactor aws_kinesis_stream_scaler
0aed528 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 requested a review from a team as a code owner December 2, 2024 18:57
@wozniakjan
Copy link
Member

wozniakjan commented Dec 2, 2024 •
edited by github-actions bot
Loading

/run-e2e aws_kinesis
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan enabled auto-merge (squash) December 2, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Scalers with new declarative scaler config
2 participants
@omerap12 @wozniakjan