Remove Prometheus metric deprecations #6339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
rickbrouwer
force-pushed
the
prometheus
branch
from
353e1fd
to
7ec52cf
Compare
|
/run-e2e sequential |
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
auto-merge was automatically disabled
November 26, 2024 12:58
Head branch was pushed to by a user without write access
wozniakjan
reviewed
Nov 26, 2024
There was a problem hiding this comment.
seems like the prometheus_metrics_test is now failing
never mind, I missed there has been a push with a fix, my bad
e2e test failure log
tests/sequential/prometheus_metrics/prometheus_metrics_test.go has failed after "two" attempts
attempt number "one"
=== RUN TestPrometheusMetrics
prometheus_metrics_test.go:4***9: --- setting up ---
helper.go:***47: deleting namespace prometheus-metrics-test-ns
helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
helper.go:***4: Creating namespace - prometheus-metrics-test-ns
helper.go:54***: Applying template: deploymentTemplate
helper.go:54***: Applying template: monitoredDeploymentTemplate
helper.go:54***: Applying template: scaledObjectTemplate
helper.go:54***: Applying template: scaledJobTemplate
helper.go:54***: Applying template: clientTemplate
helper.go:54***: Applying template: authenticatioNTemplate
helper.go:54***: Applying template: cloudEventHTTPReceiverTemplate
helper.go:54***: Applying template: cloudEventHTTPServiceTemplate
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current - ***, Target - ***
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current - ***, Target - ***
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current - ***, Target - ***
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current - ***, Target - ***
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current - ***, Target - ***
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current - ***, Target - ***
prometheus_metrics_test.go:50***: --- testing scaler metric value ---
prometheus_metrics_test.go:784: --- testing scaler metric latency ---
prometheus_metrics_test.go:789:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:789
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:44***
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_scaler_metrics_latency not available
prometheus_metrics_test.go:89***: --- testing scaler active metric ---
prometheus_metrics_test.go:5***7: --- testing scaled object errors ---
helper.go:6***0: Deleting template: scaledObjectTemplate
helper.go:54***: Applying template: wrongScaledObjectTemplate
prometheus_metrics_test.go:5***8:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:5***8
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:444
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_scaled_object_errors not available
helper.go:6***0: Deleting template: wrongScaledObjectTemplate
helper.go:54***: Applying template: scaledObjectTemplate
prometheus_metrics_test.go:569: --- testing scaled job errors ---
helper.go:6***0: Deleting template: scaledJobTemplate
helper.go:54***: Applying template: wrongScaledJobTemplate
prometheus_metrics_test.go:580:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:580
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:445
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_scaled_job_errors not available
prometheus_metrics_test.go:606: metric not available
helper.go:6***0: Deleting template: wrongScaledJobTemplate
helper.go:54***: Applying template: scaledJobTemplate
prometheus_metrics_test.go:6***5: --- testing scaler errors ---
helper.go:6***0: Deleting template: scaledObjectTemplate
helper.go:54***: Applying template: wrongScaledObjectTemplate
helper.go:6***0: Deleting template: scaledJobTemplate
helper.go:54***: Applying template: wrongScaledJobTemplate
prometheus_metrics_test.go:6***7:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:6***7
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:446
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_scaler_errors not available
helper.go:6***0: Deleting template: wrongScaledJobTemplate
helper.go:54***: Applying template: scaledJobTemplate
helper.go:6***0: Deleting template: wrongScaledObjectTemplate
helper.go:54***: Applying template: scaledObjectTemplate
prometheus_metrics_test.go:65***: --- testing scaler errors total ---
helper.go:6***0: Deleting template: scaledObjectTemplate
helper.go:54***: Applying template: wrongScaledObjectTemplate
prometheus_metrics_test.go:660:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:660
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:447
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_scaler_errors_total not available
helper.go:6***0: Deleting template: wrongScaledObjectTemplate
helper.go:54***: Applying template: scaledObjectTemplate
prometheus_metrics_test.go:9***7: --- testing operator metrics ---
prometheus_metrics_test.go:***076: --- testing trigger total metrics ---
prometheus_metrics_test.go:***079:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***079
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:9***8
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_trigger_totals not available
prometheus_metrics_test.go:***0: --- testing resource total metrics ---
prometheus_metrics_test.go:***:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:9***8
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_resource_totals not available
prometheus_metrics_test.go:***84: --- testing grpc server metrics ---
prometheus_metrics_test.go:***0***9: --- testing build info metric ---
helper.go:54***: Applying template: cronScaledJobTemplate
prometheus_metrics_test.go:***076: --- testing trigger total metrics ---
prometheus_metrics_test.go:***079:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***079
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:94***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_trigger_totals not available
prometheus_metrics_test.go:***0: --- testing resource total metrics ---
prometheus_metrics_test.go:***:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:94***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_resource_totals not available
prometheus_metrics_test.go:***84: --- testing grpc server metrics ---
prometheus_metrics_test.go:***0***9: --- testing build info metric ---
helper.go:6***0: Deleting template: cronScaledJobTemplate
prometheus_metrics_test.go:***076: --- testing trigger total metrics ---
prometheus_metrics_test.go:***079:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***079
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:944
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_trigger_totals not available
prometheus_metrics_test.go:***0: --- testing resource total metrics ---
prometheus_metrics_test.go:***:
Error Trace: /__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:944
/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
Error: Should be true
Test: TestPrometheusMetrics
Messages: keda_resource_totals not available
prometheus_metrics_test.go:***84: --- testing grpc server metrics ---
prometheus_metrics_test.go:***0***9: --- testing build info metric ---
prometheus_metrics_test.go:***405: --- testing metric server metrics ---
prometheus_metrics_test.go:***8***: --- testing grpc client metrics ---
prometheus_metrics_test.go:948: --- testing webhook metrics ---
helper.go:56***: Applying template: scaledObjectTemplate
prometheus_metrics_test.go:***6***: --- testing webhook metrics ---
prometheus_metrics_test.go:8***6: --- testing scalable objects latency ---
prometheus_metrics_test.go:858: scaledobject metric not available
prometheus_metrics_test.go:9***7: --- testing scaleobject pause metric ---
helper.go:54***: Applying template: scaledObjectPausedTemplate
helper.go:54***: Applying template: scaledObjectTemplate
prometheus_metrics_test.go:***440: --- testing cloudevent emitted ---
helper.go:6***0: Deleting template: scaledObjectTemplate
helper.go:54***: Applying template: cloudEventSourceTemplate
helper.go:54***: Applying template: scaledObjectTemplate
prometheus_metrics_test.go:***469: --- testing cloudevent emitted error ---
helper.go:6***0: Deleting template: scaledObjectTemplate
helper.go:6***0: Deleting template: cloudEventSourceTemplate
helper.go:54***: Applying template: wrongCloudEventSourceTemplate
helper.go:54***: Applying template: scaledObjectTemplate
helper.go:6***0: Deleting template: wrongCloudEventSourceTemplate
helper.go:54***: Applying template: cloudEventSourceTemplate
helper.go:6***0: Deleting template: cloudEventHTTPServiceTemplate
helper.go:6***0: Deleting template: cloudEventHTTPReceiverTemplate
helper.go:6***0: Deleting template: authenticatioNTemplate
helper.go:6***0: Deleting template: clientTemplate
helper.go:6***0: Deleting template: scaledJobTemplate
helper.go:6***0: Deleting template: scaledObjectTemplate
helper.go:6***0: Deleting template: monitoredDeploymentTemplate
helper.go:6***0: Deleting template: deploymentTemplate
helper.go:***47: deleting namespace prometheus-metrics-test-ns
helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
--- FAIL: TestPrometheusMetrics (***5***.57s)
FAIL
FAIL command-line-arguments ***5***.6***6s
FAIL
|
/run-e2e sequential |
|
@rickbrouwer hmm, still looks like e2es may need some extra care |
rickbrouwer
force-pushed
the
prometheus
branch
from
812e8ce
to
ed7379c
Compare
I have made an adjustment to the test. Only now a good check is needed to see if I have not adjusted the test too much. |
|
/run-e2e sequential |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Prometheus metric deprecations
Checklist
Docs: kedacore/keda-docs#1501
Related: #5687