Merge pull request idaholab#27290 from lindsayad/valgrind-fix-27231

Limit _stage variable to prevent OOB access
ke7kto · Apr 5, 2024 · 4781fca · 4781fca
2 parents f57cc6d + 263a7f8
commit 4781fca
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/framework/src/timeintegrators/ExplicitSSPRungeKutta.C b/framework/src/timeintegrators/ExplicitSSPRungeKutta.C
@@ -136,6 +136,12 @@ ExplicitSSPRungeKutta::solve()
     if (!converged)
       return;
   }
+
+  if (_stage == _n_stages)
+    // We made it to the end of the solve. We may call functions like computeTimeDerivatives later
+    // for postprocessing purposes in which case we need to ensure we're accessing our data
+    // correctly (e.g. not out-of-bounds)
+    --_stage;
 }
 
 bool