Skip to content

Commit

Permalink
Revert changes to check if tests are still failing
Browse files Browse the repository at this point in the history
  • Loading branch information
cupakob committed Nov 5, 2024
1 parent 7984698 commit c47050d
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 25 deletions.
12 changes: 6 additions & 6 deletions cmd/sharded-test-server/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ func startCacheServer(ctx context.Context, logDirPath, workingDir string, synthe
}

logger := klog.FromContext(ctx)
defer func() {
err = logFile.Close()
if err != nil {
logger.Error(err, "failed to close the log file")
}
}()
//defer func() {
// err = logFile.Close()
// if err != nil {
// logger.Error(err, "failed to close the log file")
// }
//}()

writer := helpers.NewHeadWriter(logFile, out)
cmd.Stdout = writer
Expand Down
12 changes: 6 additions & 6 deletions cmd/sharded-test-server/frontproxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,12 @@ func startFrontProxy(
return err
}

defer func() {
err = logFile.Close()
if err != nil {
logger.Error(err, "failed to close the log file")
}
}()
//defer func() {
// err = logFile.Close()
// if err != nil {
// logger.Error(err, "failed to close the log file")
// }
//}()

writer := helpers.NewHeadWriter(logFile, out)
cmd.Stdout = writer
Expand Down
14 changes: 7 additions & 7 deletions cmd/sharded-test-server/virtual.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,13 +209,13 @@ func (v *VirtualWorkspace) start(ctx context.Context) error {
return err
}

logger := klog.FromContext(ctx)
defer func() {
err = logFile.Close()
if err != nil {
logger.Error(err, "failed to close the log file")
}
}()
//logger := klog.FromContext(ctx)
//defer func() {
// err = logFile.Close()
// if err != nil {
// logger.Error(err, "failed to close the log file")
// }
//}()

v.writer = helpers.NewHeadWriter(logFile, out)
cmd.Stdout = v.writer
Expand Down
12 changes: 6 additions & 6 deletions cmd/test-server/kcp/shard.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ func (s *Shard) Start(ctx context.Context, quiet bool) error {
return err
}

defer func() {
err = logFile.Close()
if err != nil {
logger.Error(err, "failed to close the log file")
}
}()
//defer func() {
// err = logFile.Close()
// if err != nil {
// logger.Error(err, "failed to close the log file")
// }
//}()

s.writer = helpers.NewHeadWriter(logFile, out)
cmd.Stdout = s.writer
Expand Down

0 comments on commit c47050d

Please sign in to comment.