-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Digest AKA to Algorithm Directive from RFC 3110 and RFC 4169 #30
Conversation
a6cf329
to
032118e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update and remove some comments.
edfa820
to
e3c3c36
Compare
e3c3c36
to
f2ddf4f
Compare
I clean up the code and the commits, this PR is ready to review. @kbalt If you have time, can you please look at it? For Digest AKA the password used to generate the digest response can contain non-ascii chars. So I change the type of the password to a vector of u8.
source: https://datatracker.ietf.org/doc/html/rfc3310#section-3.3 |
f2ddf4f
to
ff924ad
Compare
Sorry, I accidentally closed this PR with a force push. Now it should be open again. |
Thanks for your effort, I will look into this when I have a bit of time to check everything out! |
Any updates on the review process? |
Thanks! |
Hi,
I added changes to match the definition for the algorithm directive from RFC 3310:
Since the no Digest AKA is supported right now, I decided to return an error on theI added a second commit to add Digest AKA in thehandle_digest_challenge
method.handle_digest_challenge
method too.Additional I decided to add some tests to check if the parsing works fine.
AKAv1: https://datatracker.ietf.org/doc/html/rfc3310#section-3.1
AKAv2: https://datatracker.ietf.org/doc/html/rfc4169#section-2