Detector and data changes #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxisi While I am reviewing some of these changes, can you create a pull request to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant changes to the way that data and PSDs are handled. It includes a new
datasub package that introducesDataandPowerSpectrumclasses.The
Dataclass stores data in the time domain, with functionality to obtain FD representations with different windows as needed; theDataclass can also retrieve strain online from GWOSC, and produce Welch estimates of the PSD (returning aPowerSpectrumobject). Future data manipulation tools (e.g., reading in GW frames) should be added to this class.The
PowerSpectrumclass includes utilities to draw simulated data, as well as interpolating to a given frequency grid.The likelihood has been modified slightly to interact with these new objects.
I have checked the
GW150914_IMRPhenomPV2.pyexample. Let me know which other examples should be working and I'll push further updates to this PR.