Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/15 fix column dtype conversion #17

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

kaymal
Copy link
Owner

@kaymal kaymal commented Apr 30, 2024

Fix #15 , where the columns cannot be converted to numeric, because there are non-value attributes (YEARWEEK in the case of `'TP.KTFTUK' series) in the json response. In many cases, all the columns are value columns; however, there seems to be cases where this doesn't work.

utils.to_dataframe() function is updated to select value columns using the series keys passed by the user. Replacing . in the series keys with _ help to find out value columns.

@kaymal kaymal added the bug Something isn't working label Apr 30, 2024
@kaymal kaymal self-assigned this Apr 30, 2024
@kaymal kaymal merged commit fb20ae1 into main Apr 30, 2024
3 checks passed
@kaymal kaymal deleted the bugfix/15-fix-column-dtype-conversion branch May 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when requesting weekly interest rates
1 participant