Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

CC: Skip test pulling image inside guest temporarily for IBM SE #5782

Merged
merged 1 commit into from
Oct 18, 2023
Merged

CC: Skip test pulling image inside guest temporarily for IBM SE #5782

merged 1 commit into from
Oct 18, 2023

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Oct 12, 2023

This PR is to skip a test Test can pull an unencrypted image inside the guest for IBM Z secure execution until the containerd is updated to v1.7.

Fixes: #5781

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@BbolroC
CC: Skip test pulling image inside guest temporarily for IBM SE
77ef946 
This PR is to skip a test `Test can pull an unencrypted image inside the guest` for IBM Z secure execution until the containerd is updated to v1.7.

Fixes: kata-containers#5781

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Oct 12, 2023
@BbolroC
Copy link
Member Author

BbolroC commented Oct 12, 2023

@stevenhorsman thanks for your advice.

@BbolroC BbolroC added the no-backport-needed Changed do not need to be applied to an older branch / repository label Oct 12, 2023
stevenhorsman
stevenhorsman approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BbolroC
Copy link
Member Author

BbolroC commented Oct 12, 2023

/test

@BbolroC
Copy link
Member Author

BbolroC commented Oct 13, 2023

I was wondering what is going on at jenkins-ci-ubuntu-20-04 which has not reported anything since yesterday.

@stevenhorsman
Copy link
Member

I was wondering what is going on at jenkins-ci-ubuntu-20-04 which has not reported anything since yesterday.

We've disabled that project, and made it not-required, but I guess this PR opened before that happened. I'll try closing and re-opening to see if that helps

@stevenhorsman stevenhorsman reopened this Oct 13, 2023
@stevenhorsman stevenhorsman reopened this Oct 13, 2023
@stevenhorsman
Copy link
Member

/test

@BbolroC
Copy link
Member Author

BbolroC commented Oct 16, 2023

Why don't we just merge this? It is just to skip a test, which does not impact nothing on other TEEs. 😉

@stevenhorsman
Copy link
Member

Why don't we just merge this? It is just to skip a test, which does not impact nothing on other TEEs. 😉

I think that is pragmatic. I'll re-run snp to give one last attempt to get it passing first.

@stevenhorsman
Copy link
Member

The SNP tests have now been failing for more than a week:
image
and this test isn't related, so I will go ahead and merge it.

@stevenhorsman stevenhorsman merged commit fec8460 into kata-containers:CCv0 Oct 18, 2023
19 checks passed
@BbolroC BbolroC deleted the skip-pulling-guest-ibm-se branch October 18, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
no-backport-needed Changed do not need to be applied to an older branch / repository size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BbolroC @stevenhorsman @katacontainersbot