Skip to content

Commit

Permalink
chore: allow phpunit 10 (#61)
Browse files Browse the repository at this point in the history
* chore: allow phpunit 10

---------

Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de>
  • Loading branch information
Chris53897 and Chris8934 authored Jul 3, 2023
1 parent 37e9d92 commit f2cc87e
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 5 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/code_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ jobs:
composer global config --no-plugins allow-plugins.symfony/flex true
composer config extra.symfony.require "${{ matrix.symfony }}"
# remove this after support for symfony 3 is dropped
- name: Remove PhpUnit 10 support for old Symfony Versions
if: matrix.symfony == '^3.4' || matrix.symfony == '^4.0'
run: composer require --no-update "phpunit/phpunit:^7|^8|^9"

- name: Install PHP dependencies
run: composer install --no-interaction

Expand Down Expand Up @@ -96,7 +101,7 @@ jobs:
run: composer install --no-interaction

- name: Run code coverage
run: vendor/bin/phpunit -v --coverage-text --coverage-clover=coverage.clover
run: vendor/bin/phpunit --coverage-text --coverage-clover=coverage.clover

- name: Send code coverage
run: |
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
# Composer files
/composer.lock
/vendor
.phpunit.result.cache
.phpunit.cache
2 changes: 1 addition & 1 deletion Tests/DependencyInjection/ConfigurationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function testProcessedConfiguration($configs, $expectedConfig)
self::assertSame($expectedConfig, $config);
}

public function dataForProcessedConfiguration()
public static function dataForProcessedConfiguration()
{
return [
[
Expand Down
4 changes: 2 additions & 2 deletions Tests/Validator/Constraints/Recaptcha3ValidatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function testInvalidCase($testToken)
->assertRaised();
}

public function invalidTokensProvider()
public static function invalidTokensProvider()
{
return [
['invalid-token'],
Expand All @@ -90,7 +90,7 @@ public function testEmptyCase($testToken)
->assertRaised();
}

public function emptyTokensProvider()
public static function emptyTokensProvider()
{
return [
[''],
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"twig/twig": "^2.9|^3.0"
},
"require-dev": {
"phpunit/phpunit": "^7|^8|^9",
"phpunit/phpunit": "^7|^8|^9|^10",
"symfony/http-client": "^4.3|^5.0|^6.0"
},
"autoload": {
Expand Down

0 comments on commit f2cc87e

Please sign in to comment.