Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support genericless pattern matching on boolean-operator interfaces #56

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

karlssberg
Copy link
Owner

Description

Expose genericless interfaces on boolean operation specs to assist with pattern matching in extension libraries

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Files Patch % Lines
Motiv/OrElse/OrElsePolicy.cs 33.33% 4 Missing ⚠️
Motiv/And/AndSpec.cs 0.00% 2 Missing ⚠️
Motiv/AndAlso/AndAlsoSpec.cs 0.00% 2 Missing ⚠️
Motiv/Not/NotPolicy.cs 0.00% 2 Missing ⚠️
Motiv/Not/NotSpec.cs 0.00% 2 Missing ⚠️
Motiv/Or/OrSpec.cs 0.00% 2 Missing ⚠️
Motiv/OrElse/OrElseSpec.cs 0.00% 2 Missing ⚠️
Motiv/XOr/XOrSpec.cs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
Motiv/And/AndSpec.cs 77.77% <0.00%> (-9.73%) ⬇️
Motiv/AndAlso/AndAlsoSpec.cs 82.60% <0.00%> (-7.87%) ⬇️
Motiv/Not/NotPolicy.cs 45.45% <0.00%> (-10.11%) ⬇️
Motiv/Not/NotSpec.cs 50.00% <0.00%> (-5.56%) ⬇️
Motiv/Or/OrSpec.cs 72.22% <0.00%> (-9.03%) ⬇️
Motiv/OrElse/OrElseSpec.cs 60.86% <0.00%> (-5.80%) ⬇️
Motiv/XOr/XOrSpec.cs 61.11% <0.00%> (-7.64%) ⬇️
Motiv/OrElse/OrElsePolicy.cs 69.56% <33.33%> (-14.65%) ⬇️

@karlssberg karlssberg merged commit 9c99940 into main Aug 1, 2024
4 checks passed
@karlssberg karlssberg deleted the feature/support-genericless-pattern-matching branch August 1, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants