-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move input unit conversion and bounds checking to base class #240
Conversation
Please add a description to this PR to describe in words the goal. Thanks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 99.89% 99.66% -0.23%
==========================================
Files 9 9
Lines 938 900 -38
==========================================
- Hits 937 897 -40
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a a really nice PR. Really neat to see how to use the astropy modeling machinery to get the units in x right. Thanks for putting it in.
6b4204d
to
4b977da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
There are two goals of this PR: