Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the player view when destroy player #471

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

passerbyloo
Copy link

Description of the Changes

when call player.destroy().
the player view still not remove/release, like

player.destroy()
player = PlayKitManager.sharedInstance.loadPlayer(config: config)
playerView = PlayerView.createPlayerViewForPlayer(player)

if play the same video source in two player, the video can not play normally.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant